<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Dec 12, 2016 at 2:35 PM, Niels de Vos <span dir="ltr"><<a target="_blank" href="mailto:ndevos@redhat.com">ndevos@redhat.com</a>></span> wrote:<br><blockquote style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex" class="gmail_quote"><span class="gmail-">On Mon, Dec 12, 2016 at 02:27:53PM +0530, Ravishankar N wrote:<br>
> On 12/12/2016 02:10 PM, Pranith Kumar Karampuri wrote:<br>
> ><br>
> ><br>
> > On Sun, Dec 11, 2016 at 1:48 PM, Niels de Vos <<a href="mailto:ndevos@redhat.com">ndevos@redhat.com</a><br>
</span><span class="gmail-">> > <mailto:<a href="mailto:ndevos@redhat.com">ndevos@redhat.com</a>>> wrote:<br>
> ><br>
> > We've mentioned earlier that only (small) patches for bugfixes and<br>
> > stabilization should get backported. Yet there is a patch with<br>
> > +470/-61<br>
> > lines proposed for inclusion. This is not something that is normally<br>
> > suitable for backporting, so I'd like to get the opinion of several<br>
> > maintainers before it gets merged.<br>
> ><br>
><br>
> The patch is entirely in AFR, so in addition to Pranith, which specific<br>
> maintainers would you like a review from?<br>
<br>
</span>Anyone who has an opinion. We may want/need to introduce additional<br>
steps to get big patches liks this backported and merged. I do not deem<br>
a review of any single maintainer sufficient for bug changes like this,<br>
and definitely not for patches to stable branches.<br>
<span class="gmail-"><br>
> > afr: allow I/O when favorite-child-policy is enabled<br>
</span>> > <a target="_blank" rel="noreferrer" href="http://review.gluster.org/16091">http://review.gluster.org/<wbr>16091</a> <<a target="_blank" rel="noreferrer" href="http://review.gluster.org/16091">http://review.gluster.org/<wbr>16091</a>><br>
<span class="gmail-">> ><br>
> > It sounds like a serious bugfix, but I'd like to know if there is any<br>
> > risk for users of a version that has this patch.<br>
> ><br>
><br>
><br>
> I don't think there is any risk in taking the patch in. The bug<br>
> (<a target="_blank" rel="noreferrer" href="https://bugzilla.redhat.com/show_bug.cgi?id=1378547">https://bugzilla.redhat.com/<wbr>show_bug.cgi?id=1378547</a><br>
> ) was raised by Ubisoft on 3.8. I can set a need-info on the BZ to see if<br>
> they would be willing to test it out. If they can, and find the fix to be<br>
> working, can you take the patch in?<br>
<br>
</span>Yes, I would appreciate that. Reasonable additional testing of normal<br>
AFR functioning would be very good too.<br></blockquote><div><br></div><div>Can we take this patch in for next 3.8.x release based on: <a href="https://bugzilla.redhat.com/show_bug.cgi?id=1378547#c6">https://bugzilla.redhat.com/show_bug.cgi?id=1378547#c6</a> from the ubisoft guys who tested different cases with the fix?<br></div><div> </div><blockquote style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex" class="gmail_quote">
<br>
Thanks!<br>
Niels<br>
<span class="gmail-"><br>
<br>
><br>
> Thanks,<br>
> Ravi<br>
><br>
><br>
> > The version for the<br>
> > master branch has only been there for 2 weeks, and the 3.9 version has<br>
> > not been merged yet either.<br>
> ><br>
> ><br>
> > We are awaiting netbsd regression to pass for merging it in 3.9. I will<br>
> > be planning to get this in for 3.9.1.<br>
> ><br>
> ><br>
> > Thanks,<br>
> > Niels<br>
> ><br>
> > ______________________________<wbr>_________________<br>
> > maintainers mailing list<br>
</span>> > <a href="mailto:maintainers@gluster.org">maintainers@gluster.org</a> <mailto:<a href="mailto:maintainers@gluster.org">maintainers@gluster.<wbr>org</a>><br>
> > <a target="_blank" rel="noreferrer" href="http://www.gluster.org/mailman/listinfo/maintainers">http://www.gluster.org/<wbr>mailman/listinfo/maintainers</a><br>
> > <<a target="_blank" rel="noreferrer" href="http://www.gluster.org/mailman/listinfo/maintainers">http://www.gluster.org/<wbr>mailman/listinfo/maintainers</a>><br>
> ><br>
> ><br>
> ><br>
> ><br>
> > --<br>
> > Pranith<br>
><br>
><br>
</blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature"><div dir="ltr">Pranith<br></div></div>
</div></div>