<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Oct 6, 2016 at 1:49 AM, Michael Adam <span dir="ltr"><<a target="_blank" href="mailto:obnox@samba.org">obnox@samba.org</a>></span> wrote:<br><blockquote style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex" class="gmail_quote">On 2016-10-05 at 09:45 -0400, Ira Cooper wrote:<br>
> "Feedback-given-by: <nosy.person@silly.place>"<br></blockquote><div><br>Niels/Nigel,<br></div><div> Is this easier to do?<br></div><div> </div><blockquote style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex" class="gmail_quote">
<br>
I like that one - thanks! :-)<br>
<span class="gmail-HOEnZb"><font color="#888888"><br>
Michael<br>
</font></span><div class="gmail-HOEnZb"><div class="gmail-h5"><br>
> ----- Original Message -----<br>
> > On 2016-09-30 at 17:52 +0200, Niels de Vos wrote:<br>
> > > On Fri, Sep 30, 2016 at 08:50:12PM +0530, Ravishankar N wrote:<br>
> > > > On 09/30/2016 06:38 PM, Niels de Vos wrote:<br>
> > > > > On Fri, Sep 30, 2016 at 07:11:51AM +0530, Pranith Kumar Karampuri<br>
> > > > > wrote:<br>
> > > ...<br>
> > > > > Maybe we can add an additional tag that mentions all the people that<br>
> > > > > did do reviews of older versions of the patch. Not sure what the tag<br>
> > > > > would be, maybe just CC?<br>
> > > > It depends on what tags would be processed to obtain statistics on review<br>
> > > > contributions.<br>
> > ><br>
> > > Real statistics would come from Gerrit, not from the 'git log' output.<br>
> > > We do have a ./extras/who-wrote-glusterfs/ in the sources, but that is<br>
> > > only to get an idea about the changes that were made and should not be<br>
> > > used for serious statistics.<br>
> > ><br>
> > > It is possible to feed the Gerrit comment-stream into things like<br>
> > > Elasticsearch and get an accurate impression how many reviews people do<br>
> > > (and much more). I hope we can get some contribution diagrams from<br>
> > > someting like this at one point.<br>
> > ><br>
> > > Would some kind of Gave-feedback tag for people that left a comment on<br>
> > > earlier versions of the patch be appreciated by others? It will show in<br>
> > > the 'git log' who was involved in some way or form.<br>
> ><br>
> > I think this would be fair.<br>
> ><br>
> > Reviewed-by tags should imho be reserved for the final<br>
> > incarnation of the patch. Those mean that the person named<br>
> > in the tag has aproved this version of the patch for getting<br>
> > into the official tree. A previous version of the patch can<br>
> > have been entirely different, so a reviewed-by for that<br>
> > previous version may not actually apply to the new version at all<br>
> > and hence create a false impression!<br>
> ><br>
> > It is also difficult to track all activities by tags,<br>
> > and anyone who wants to measure performance and contributions<br>
> > only by looking at git commit tags will not be doing several<br>
> > people justice. We could add 'discussed-with' or 'designed-by'<br>
> > tags, etc ... ;-)<br>
> ><br>
> > On a serious note, in Samba we use 'Pair-programmed-with' tags,<br>
> > because we do pair-programming a lot, but only one person can<br>
> > be an author of a git commit ...<br>
> ><br>
> > The 'Gave-feedback' tag I do like. even though it does<br>
> > not quite match with the foobar-by pattern of other tags.<br>
> ><br>
> > Michael<br>
> ><br>
> > ______________________________<wbr>_________________<br>
> > Gluster-devel mailing list<br>
> > <a href="mailto:Gluster-devel@gluster.org">Gluster-devel@gluster.org</a><br>
> > <a target="_blank" rel="noreferrer" href="http://www.gluster.org/mailman/listinfo/gluster-devel">http://www.gluster.org/<wbr>mailman/listinfo/gluster-devel</a><br>
</div></div><br>______________________________<wbr>_________________<br>
maintainers mailing list<br>
<a href="mailto:maintainers@gluster.org">maintainers@gluster.org</a><br>
<a target="_blank" rel="noreferrer" href="http://www.gluster.org/mailman/listinfo/maintainers">http://www.gluster.org/<wbr>mailman/listinfo/maintainers</a><br>
<br></blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature"><div dir="ltr">Pranith<br></div></div>
</div></div>