<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Sep 15, 2016 at 2:56 PM, Nigel Babu <span dir="ltr"><<a href="mailto:nigelb@redhat.com" target="_blank">nigelb@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Wed, Sep 07, 2016 at 10:21:38PM +0530, Pranith Kumar Karampuri wrote:<br>
> ><br>
> > These massive changes +1500 lines of code, have not one test. Eventhough<br>
> > a new volume option is introduced. I really do hope there is some test<br>
> > in the master branch that runs soemthing useful with the new option<br>
> > enabled. Could you please backport that test-case too?<br>
> ><br>
><br>
> These patches are stabilization of experimental feature compound-fops for<br>
> 3.8.x that is why you see massive changes because it is still stabilizing.<br>
> As per the guidelines it is okay to do this. As this is performance<br>
> enhancement, the nature of tests we did were manual and comparing the time<br>
> elapsed with and without the fixes. We see 10% performance improvement<br>
> overall in small file create workload where the write workload is 40% where<br>
> the enhancement comes into picture. That is the reason you don't see any<br>
> automated test as I don't think we can reliably test the performance<br>
> improvement at the moment in automation. May be we can integrate it with<br>
> the one Nigel & Shyam are driving once it is available.<br>
<br>
</span>The performance testing that Shyam and I are driving will not help test these<br>
sort of scenarios. We do not have enough machines to run performance tests that<br>
are this fine-grained.<br></blockquote><div><br></div><div>Goal is to flip the default option to use this option in some time. So it will be exercised whether we want it or not if you have replica volume.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
--<br>
nigelb<br>
</blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">Pranith<br></div></div>
</div></div>