<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Sep 7, 2016 at 10:21 PM, Pranith Kumar Karampuri <span dir="ltr"><<a href="mailto:pkarampu@redhat.com" target="_blank">pkarampu@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span class="">On Wed, Sep 7, 2016 at 8:00 PM, Niels de Vos <span dir="ltr"><<a href="mailto:ndevos@redhat.com" target="_blank">ndevos@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Krutika and Pranith,<br>
<br>
The patches that introduce the compound operations for release-3.8 are<br>
almost ready for merging. Is there a particular order for the merging to<br>
be done? I'd hate to break git-bisect if I do it in the wrong order.<br>
<br>
<a href="http://review.gluster.org/#/q/status:open+project:glusterfs+branch:release-3.8+topic:bug-1372693" rel="noreferrer" target="_blank">http://review.gluster.org/#/q/<wbr>status:open+project:glusterfs+<wbr>branch:release-3.8+topic:bug-1<wbr>372693</a><br>
<br>
These massive changes +1500 lines of code, have not one test. Eventhough<br>
a new volume option is introduced. I really do hope there is some test<br>
in the master branch that runs soemthing useful with the new option<br>
enabled. Could you please backport that test-case too?<br></blockquote><div><br></div></span><div>These patches are stabilization of experimental feature compound-fops for 3.8.x that is why you see massive changes because it is still stabilizing. As per the guidelines it is okay to do this. As this is performance enhancement, the nature of tests we did were manual and comparing the time elapsed with and without the fixes. We see 10% performance improvement overall in small file create workload where the write workload is 40% where the enhancement comes into picture. That is the reason you don't see any automated test as I don't think we can reliably test the performance improvement at the moment in automation. May be we can integrate it with the one Nigel & Shyam are driving once it is available.<br></div><span class=""><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Because this adds a new functionality based on the (experimental)<br>
compount FOPs, we need to mention it in the release notes. Feel free to<br>
start a new doc/release-notes/<a href="http://3.8.x.md" rel="noreferrer" target="_blank">3.8.x.md</a> with a little text about the<br>
goal of feature, how users can enable it and verify results.<br></blockquote><div><br></div></span><div>Hmm... it is not a feature, it is stabilization of feature and using it. We can probably add a short description of how the option needs to be used to take advantage of the perf enhancement in the bz. It can be taken as part of the normal process of aggregating release notes.<br></div><span class=""><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
I really want us to prevent introducing such a lot of new code, that<br>
does not go through regular testing. Should this be included in 3.8.4,<br>
or maybe the release after it?<br></blockquote><div><br></div></span><div>For it to go through regular testing, by default the option use-compound-fops needs to be enabled, but since all of this is still experimental, I would like it to be disabled. What are the tentative release dates for 3.8.4/3.8.5?<br></div></div></div></div></blockquote><div><br></div><div>I see that you plan to release it sometime next week. I think it is safer to merge these just after the tagging so that it will go to 3.8.5. It will also lessen the probability of surprises.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Thanks,<br>
Niels<span class="HOEnZb"><font color="#888888"><br>
</font></span></blockquote></div><span class="HOEnZb"><font color="#888888"><br><br clear="all"><br>-- <br><div data-smartmail="gmail_signature"><div dir="ltr">Pranith<br></div></div>
</font></span></div></div>
</blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">Pranith<br></div></div>
</div></div>