<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Jan 15, 2016 at 4:22 PM, Niels de Vos <span dir="ltr"><<a href="mailto:ndevos@redhat.com" target="_blank">ndevos@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Thu, Jan 14, 2016 at 10:26:46PM +0530, Kaushal M wrote:<br>
</span><span class="">> I'd pushed the config to a new branch instead of updating the<br>
> `refs/meta/config` branch. I've corrected this now.<br>
><br>
> The 3 new labels are,<br>
> - Smoke<br>
> - CentOS-regression<br>
> - NetBSD-regression<br>
><br>
> The new labels are active now. Changes cannot be merged without all of<br>
> them being +1. Only the bot accounts (Gluster Build System and NetBSD<br>
> Build System) can set them.<br></span></blockquote><div><br></div><div>Thanks Kaushal !</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">
<br>
</span>It seems that Verified is also a label that is required. Because this is<br>
now the label for manual testing by reviewers/qa, I do not think it<br>
should be a requirement anymore.<br>
<br>
Could the labels that are needed for merging be setup like this?<br>
<br>
Code-Review=+2 && (Verified=+1 || (Smoke=+1 && CentOS-regression=+1 && NetBSD-regression=+1))<br></blockquote><div><br></div><div>I would prefer not having Verified=+1 here. A dev should not be allowed to override the restrictions.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
I managed to get <a href="http://review.gluster.org/13208" rel="noreferrer" target="_blank">http://review.gluster.org/13208</a> merged now, please<br>
check if the added tags in the commit message are ok, or need to get<br>
modified.<br>
<br>
Thanks,<br>
Niels<br>
<div class="HOEnZb"><div class="h5"><br>
<br>
><br>
> On Thu, Jan 14, 2016 at 9:22 PM, Kaushal M <<a href="mailto:kshlmster@gmail.com">kshlmster@gmail.com</a>> wrote:<br>
> > On Thu, Jan 14, 2016 at 5:12 PM, Niels de Vos <<a href="mailto:ndevos@redhat.com">ndevos@redhat.com</a>> wrote:<br>
> >> On Thu, Jan 14, 2016 at 03:46:02PM +0530, Kaushal M wrote:<br>
> >>> On Thu, Jan 14, 2016 at 2:43 PM, Niels de Vos <<a href="mailto:ndevos@redhat.com">ndevos@redhat.com</a>> wrote:<br>
> >>> > On Thu, Jan 14, 2016 at 11:51:15AM +0530, Raghavendra Talur wrote:<br>
> >>> >> On Tue, Jan 12, 2016 at 7:59 PM, Atin Mukherjee <<a href="mailto:atin.mukherjee83@gmail.com">atin.mukherjee83@gmail.com</a>><br>
> >>> >> wrote:<br>
> >>> >><br>
> >>> >> > -Atin<br>
> >>> >> > Sent from one plus one<br>
> >>> >> > On Jan 12, 2016 7:41 PM, "Niels de Vos" <<a href="mailto:ndevos@redhat.com">ndevos@redhat.com</a>> wrote:<br>
> >>> >> > ><br>
> >>> >> > > On Tue, Jan 12, 2016 at 07:21:37PM +0530, Raghavendra Talur wrote:<br>
> >>> >> > > > We have now changed the gerrit-jenkins workflow as follows:<br>
> >>> >> > > ><br>
> >>> >> > > > 1. Developer works on a new feature/bug fix and tests it locally(run<br>
> >>> >> > > > run-tests.sh completely).<br>
> >>> >> > > > 2. Developer sends the patch to gerrit using rfc.sh.<br>
> >>> >> > > ><br>
> >>> >> > > > +++Note that no regression runs have started automatically for this<br>
> >>> >> > patch<br>
> >>> >> > > > at this point.+++<br>
> >>> >> > > ><br>
> >>> >> > > > 3. Developer marks the patch as +1 verified on gerrit as a promise of<br>
> >>> >> > > > having tested the patch completely. For cases where patches don't have<br>
> >>> >> > a +1<br>
> >>> >> > > > verified from the developer, maintainer has the following options<br>
> >>> >> > > > a. just do the code-review and award a +2 code review.<br>
> >>> >> > > > b. pull the patch locally and test completely and award a +1 verified.<br>
> >>> >> > > > Both the above actions would result in triggering of regression runs<br>
> >>> >> > for<br>
> >>> >> > > > the patch.<br>
> >>> >> > ><br>
> >>> >> > > Would it not help if anyone giving +1 code-review starts the regression<br>
> >>> >> > > tests too? When developers ask me to review, I prefer to see reviews<br>
> >>> >> > > done by others first, and any regression failures should have been fixed<br>
> >>> >> > > by the time I look at the change.<br>
> >>> >> > When this idea was originated (long back) I was in favour of having<br>
> >>> >> > regression triggered on a +1, however verified flag set by the developer<br>
> >>> >> > would still trigger the regression. Being a maintainer I would always<br>
> >>> >> > prefer to look at a patch when its verified flag is +1 which means the<br>
> >>> >> > regression result would also be available.<br>
> >>> >> ><br>
> >>> >><br>
> >>> >><br>
> >>> >> Niels requested in IRC that it is good have a mechanism of getting all<br>
> >>> >> patches that have already passed all regressions before starting review.<br>
> >>> >> Here is what I found<br>
> >>> >> a. You can use the search string<br>
> >>> >> status:open label:Verified+1,user=build AND label:Verified+1,user=nb7build<br>
> >>> >> b. You can bookmark this link and it will take you directly to the page<br>
> >>> >> with list of such patches.<br>
> >>> >><br>
> >>> >> <a href="http://review.gluster.org/#/q/status:open+label:Verified%252B1%252Cuser%253Dbuild+AND+label:Verified%252B1%252Cuser%253Dnb7build" rel="noreferrer" target="_blank">http://review.gluster.org/#/q/status:open+label:Verified%252B1%252Cuser%253Dbuild+AND+label:Verified%252B1%252Cuser%253Dnb7build</a><br>
> >>> ><br>
> >>> > Hmm, copy/pasting this URL does not work for me, I get an error:<br>
> >>> ><br>
> >>> > Code Review - Error<br>
> >>> > line 1:26 no viable alternative at character '%'<br>
> >>> > [Continue]<br>
> >>> ><br>
> >>> ><br>
> >>> > Kaushal, could you add the following labels to gerrit, so that we can<br>
> >>> > update the Jenkins jobs and they can start setting their own labels?<br>
> >>> ><br>
> >>> > <a href="http://review.gluster.org/Documentation/config-labels.html#label_custom" rel="noreferrer" target="_blank">http://review.gluster.org/Documentation/config-labels.html#label_custom</a><br>
> >>> ><br>
> >>> > - Smoke: misc smoke testing, compile, bug check, posix, ..<br>
> >>> > - NetBSD: NetBSD-7 regression<br>
> >>> > - Linux: Linux regression on CentOS-6<br>
> >>><br>
> >>> I added these labels to the gluster projects' project.config, but they<br>
> >>> don't seem to be showing up. I'll check once more when I get back<br>
> >>> home.<br>
> >><br>
> >> Might need a restart/reload of Gerrit? It seems required for the main<br>
> >> gerrit.config file too:<br>
> >><br>
> >> <a href="http://review.gluster.org/Documentation/config-gerrit.html#_file_code_etc_gerrit_config_code" rel="noreferrer" target="_blank">http://review.gluster.org/Documentation/config-gerrit.html#_file_code_etc_gerrit_config_code</a><br>
> ><br>
> > I was using Chromium and did a restart. Both hadn't helped. I'll try again.<br>
> >><br>
> >> Niels<br>
</div></div></blockquote></div><br></div></div>