<p dir="ltr"></p>
<p dir="ltr">-Atin<br>
Sent from one plus one<br>
On Jan 12, 2016 7:41 PM, "Niels de Vos" <<a href="mailto:ndevos@redhat.com">ndevos@redhat.com</a>> wrote:<br>
><br>
> On Tue, Jan 12, 2016 at 07:21:37PM +0530, Raghavendra Talur wrote:<br>
> > We have now changed the gerrit-jenkins workflow as follows:<br>
> ><br>
> > 1. Developer works on a new feature/bug fix and tests it locally(run<br>
> > run-tests.sh completely).<br>
> > 2. Developer sends the patch to gerrit using rfc.sh.<br>
> ><br>
> > +++Note that no regression runs have started automatically for this patch<br>
> > at this point.+++<br>
> ><br>
> > 3. Developer marks the patch as +1 verified on gerrit as a promise of<br>
> > having tested the patch completely. For cases where patches don't have a +1<br>
> > verified from the developer, maintainer has the following options<br>
> > a. just do the code-review and award a +2 code review.<br>
> > b. pull the patch locally and test completely and award a +1 verified.<br>
> > Both the above actions would result in triggering of regression runs for<br>
> > the patch.<br>
><br>
> Would it not help if anyone giving +1 code-review starts the regression<br>
> tests too? When developers ask me to review, I prefer to see reviews<br>
> done by others first, and any regression failures should have been fixed<br>
> by the time I look at the change.<br>
When this idea was originated (long back) I was in favour of having regression triggered on a +1, however verified flag set by the developer would still trigger the regression. Being a maintainer I would always prefer to look at a patch when its verified flag is +1 which means the regression result would also be available.<br>
><br>
> Niels<br>
><br>
> ><br>
> > 4. Once the regression runs complete, verification verdict is passed onto<br>
> > gerrit by jenkins<br>
> > and maintainer can proceed with the merge using submit button.<br>
> ><br>
> > Thanks,<br>
> > Raghavendra Talur<br>
><br>
> > _______________________________________________<br>
> > maintainers mailing list<br>
> > <a href="mailto:maintainers@gluster.org">maintainers@gluster.org</a><br>
> > <a href="http://www.gluster.org/mailman/listinfo/maintainers">http://www.gluster.org/mailman/listinfo/maintainers</a><br>
><br>
><br>
> _______________________________________________<br>
> Gluster-devel mailing list<br>
> <a href="mailto:Gluster-devel@gluster.org">Gluster-devel@gluster.org</a><br>
> <a href="http://www.gluster.org/mailman/listinfo/gluster-devel">http://www.gluster.org/mailman/listinfo/gluster-devel</a><br>
</p>