<html>
  <head>
    <meta content="text/html; charset=windows-1252"
      http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    <div class="moz-cite-prefix">On 11/14/2016 05:57 PM, Atin Mukherjee
      wrote:<br>
    </div>
    <blockquote
cite="mid:CAGNCGH2gM-UADtCcPBzThU7TYW-Hc22zngPdE2E4LmHf+3CZjg@mail.gmail.com"
      type="cite">
      <div dir="ltr">This would be a straight forward thing to implement
        at glusterd, anyone up for it? If not, we will take this into
        consideration for GlusterD 2.0.<br>
      </div>
      <div class="gmail_extra"><br>
        <div class="gmail_quote">On Mon, Nov 14, 2016 at 10:28 AM,
          Mohammed Rafi K C <span dir="ltr">&lt;<a
              moz-do-not-send="true" href="mailto:rkavunga@redhat.com"
              target="_blank">rkavunga@redhat.com</a>&gt;</span> wrote:<br>
          <blockquote class="gmail_quote" style="margin:0 0 0
            .8ex;border-left:1px #ccc solid;padding-left:1ex">
            <div bgcolor="#FFFFFF" text="#000000">
              <p>I think it is worth to implement a lock option.</p>
              <p>+1</p>
              <p><br>
              </p>
              <p>Rafi KC<br>
              </p>
              <div>
                <div class="h5"> <br>
                  <div class="m_-4070630736712633266moz-cite-prefix">On
                    11/14/2016 06:12 AM, David Gossage wrote:<br>
                  </div>
                  <blockquote type="cite">
                    <div dir="ltr">
                      <div class="gmail_extra">
                        <div>
                          <div
                            class="m_-4070630736712633266gmail_signature"
                            data-smartmail="gmail_signature">
                            <div dir="ltr">
                              <div>On Sun, Nov 13, 2016 at 6:35 PM,
                                Lindsay Mathieson <span dir="ltr">&lt;<a
                                    moz-do-not-send="true"
                                    href="mailto:lindsay.mathieson@gmail.com"
                                    target="_blank">lindsay.mathieson@gmail.com</a>&gt;</span>
                                wrote:<br>
                              </div>
                            </div>
                          </div>
                        </div>
                        <div class="gmail_quote">
                          <blockquote class="gmail_quote"
                            style="margin:0 0 0 .8ex;border-left:1px
                            #ccc solid;padding-left:1ex">As discussed
                            recently, it is way to easy to make
                            destructive changes<br>
                            to a volume,e.g change shard size. This can
                            corrupt the data with no<br>
                            warnings and its all to easy to make a typo
                            or access the wrong volume<br>
                            when doing 3am maintenance ...<br>
                            <br>
                            So I'd like to suggest something like the
                            following:<br>
                            <br>
                              gluster volume lock &lt;volname&gt;<br>
                          </blockquote>
                        </div>
                      </div>
                    </div>
                  </blockquote>
                </div>
              </div>
            </div>
          </blockquote>
        </div>
      </div>
    </blockquote>
    <br>
    <tt><br>
    </tt><tt>I don't think this is a good idea. It would make more sense
      to give out verbose warnings in the individual commands
      themselves. A volume lock doesn't prevent users from unlocking and
      still inadvertently running those commands without knowing the
      implications. The remove brick set of commands provides verbose
      messages nicely:</tt><tt><br>
    </tt><tt><br>
    </tt><font color="#3366ff"><tt>$gluster v remove-brick testvol
        127.0.0.2:/home/ravi/bricks/brick{4..6} commit</tt><tt><br>
      </tt><tt>Removing brick(s) can result in data loss. Do you want to
        Continue? (y/n) y</tt><tt><br>
      </tt><tt>volume remove-brick commit: success</tt><tt><br>
      </tt><tt>Check the removed bricks to ensure all files are
        migrated.</tt><tt><br>
      </tt><tt>If files with data are found on the brick path, copy them
        via a gluster mount point before re-purposing the removed brick</tt><tt><br>
      </tt><tt>
      </tt></font><tt><br>
    </tt><tt>My 2 cents,</tt><tt><br>
    </tt><tt>Ravi</tt><br>
    <br>
    <br>
    <blockquote
cite="mid:CAGNCGH2gM-UADtCcPBzThU7TYW-Hc22zngPdE2E4LmHf+3CZjg@mail.gmail.com"
      type="cite">
      <div class="gmail_extra">
        <div class="gmail_quote">
          <blockquote class="gmail_quote" style="margin:0 0 0
            .8ex;border-left:1px #ccc solid;padding-left:1ex">
            <div bgcolor="#FFFFFF" text="#000000">
              <div>
                <div class="h5">
                  <blockquote type="cite">
                    <div dir="ltr">
                      <div class="gmail_extra">
                        <div class="gmail_quote">
                          <blockquote class="gmail_quote"
                            style="margin:0 0 0 .8ex;border-left:1px
                            #ccc solid;padding-left:1ex"> <br>
                            Setting this would fail all:<br>
                            - setting changes<br>
                            - add bricks<br>
                            - remove bricks<br>
                            - delete volume<br>
                            <br>
                              gluster volume unlock &lt;volname&gt;<br>
                            <br>
                            would allow all changes to be made.<br>
                            <br>
                            Just a thought, open to alternate
                            suggestions.<br>
                            <br>
                            Thanks<br>
                            <span class="m_-4070630736712633266HOEnZb"><font
                                color="#888888"><br>
                              </font></span></blockquote>
                          <div>+</div>
                          <div>sounds handy </div>
                          <blockquote class="gmail_quote"
                            style="margin:0 0 0 .8ex;border-left:1px
                            #ccc solid;padding-left:1ex"><span
                              class="m_-4070630736712633266HOEnZb"><font
                                color="#888888"> --<br>
                                Lindsay<br>
                                ______________________________<wbr>_________________<br>
                                Gluster-users mailing list<br>
                                <a moz-do-not-send="true"
                                  href="mailto:Gluster-users@gluster.org"
                                  target="_blank">Gluster-users@gluster.org</a><br>
                                <a moz-do-not-send="true"
                                  href="http://www.gluster.org/mailman/listinfo/gluster-users"
                                  rel="noreferrer" target="_blank">http://www.gluster.org/mailman<wbr>/listinfo/gluster-users</a><br>
                              </font></span></blockquote>
                        </div>
                        <br>
                      </div>
                    </div>
                    <br>
                    <fieldset
                      class="m_-4070630736712633266mimeAttachmentHeader"></fieldset>
                    <br>
                    <pre>______________________________<wbr>_________________
Gluster-users mailing list
<a moz-do-not-send="true" class="m_-4070630736712633266moz-txt-link-abbreviated" href="mailto:Gluster-users@gluster.org" target="_blank">Gluster-users@gluster.org</a>
<a moz-do-not-send="true" class="m_-4070630736712633266moz-txt-link-freetext" href="http://www.gluster.org/mailman/listinfo/gluster-users" target="_blank">http://www.gluster.org/<wbr>mailman/listinfo/gluster-users</a></pre>
    </blockquote>
    

  </div></div></div>


______________________________<wbr>_________________

Gluster-devel mailing list

<a moz-do-not-send="true" href="mailto:Gluster-devel@gluster.org">Gluster-devel@gluster.org</a>

<a moz-do-not-send="true" href="http://www.gluster.org/mailman/listinfo/gluster-devel" rel="noreferrer" target="_blank">http://www.gluster.org/<wbr>mailman/listinfo/gluster-devel</a>
</blockquote></div>


-- 
<div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr">
</div><div>~ Atin (atinm)
</div></div></div></div>
</div>


<fieldset class="mimeAttachmentHeader"></fieldset>
<pre wrap="">_______________________________________________
Gluster-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Gluster-devel@gluster.org">Gluster-devel@gluster.org</a>
<a class="moz-txt-link-freetext" href="http://www.gluster.org/mailman/listinfo/gluster-devel">http://www.gluster.org/mailman/listinfo/gluster-devel</a></pre>

</blockquote><p>
</p></body></html>