<html>
  <head>
    <meta content="text/html; charset=utf-8" http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    <p><br>
    </p>
    <br>
    <div class="moz-cite-prefix">On 19/10/16 20:54, Jackie Tung wrote:<br>
    </div>
    <blockquote cite="mid:DC6825B5-A347-424A-8971-AB31DC5E2305@drive.ai"
      type="cite">
      <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
      <div class="">Thanks Jiffin, filed <a moz-do-not-send="true"
          href="https://bugzilla.redhat.com/show_bug.cgi?id=1386766"
          class="">https://bugzilla.redhat.com/show_bug.cgi?id=1386766</a></div>
      <div class=""><br class="">
      </div>
      <div class="">In my limited knowledge of the original reasons for
        1GB hardcode, either removing the limit altogether, or an
        additional “override" option parameter would be preferable in my
        humble opinion.</div>
      <br class="">
    </blockquote>
    <br>
    <br>
    Thanks for filing the bug, patch posted for addressing this issue <a
      href="http://review.gluster.org/15689">http://review.gluster.org/15689<font
        color="#000000"></font></a><br>
    --<br>
    Jiffin<br>
    <br>
    <blockquote cite="mid:DC6825B5-A347-424A-8971-AB31DC5E2305@drive.ai"
      type="cite">
      <div>
        <blockquote type="cite" class="">
          <div class="">On Oct 19, 2016, at 2:02 AM, Jiffin Tony Thottan
            &lt;<a moz-do-not-send="true"
              href="mailto:jthottan@redhat.com" class="">jthottan@redhat.com</a>&gt;
            wrote:</div>
          <br class="Apple-interchange-newline">
          <div class="">
            <meta content="text/html; charset=utf-8"
              http-equiv="Content-Type" class="">
            <div bgcolor="#FFFFFF" text="#000000" class="">
              <p class="">Hi Jackie,<br class="">
              </p>
              <br class="">
              <div class="moz-cite-prefix">On 18/10/16 23:48, Jackie
                Tung wrote:<br class="">
              </div>
              <blockquote
                cite="mid:35E4CA0F-B0C3-4B70-B6FB-B34F133F8F4E@drive.ai"
                type="cite" class="">
                <meta http-equiv="Content-Type" content="text/html;
                  charset=utf-8" class="">
                Hi all,
                <div class=""><br class="">
                </div>
                <div class="">Documentation says:  <a
                    moz-do-not-send="true"
href="https://gluster.readthedocs.io/en/latest/Administrator%20Guide/Trash/"
                    style="font-family: Lato, proxima-nova, 'Helvetica
                    Neue', Arial, sans-serif; font-size: 16px; orphans:
                    2; widows: 2; background-color: rgb(252, 252, 252);"
                    class="">https://gluster.readthedocs.io/en/latest/Administrator%20Guide/Trash/</a></div>
                <div class=""><br class="">
                </div>
                <div class="">
                  <p style="box-sizing: border-box; line-height: 24px;
                    margin: 0px 0px 12px; font-size: 16px; color:
                    rgb(64, 64, 64); font-family: Lato, proxima-nova,
                    'Helvetica Neue', Arial, sans-serif;
                    font-variant-ligatures: normal; orphans: 2; widows:
                    2; background-color: rgb(252, 252, 252);" class=""><strong
                      style="box-sizing: border-box;" class=""><em
                        style="box-sizing: border-box;" class="">gluster
                        volume set &lt;VOLNAME&gt;
                        features.trash-max-filesize &lt;size&gt;</em></strong></p>
                  <div style="box-sizing: border-box; line-height: 24px;
                    margin: 0px; font-size: 16px; font-family: Lato,
                    proxima-nova, 'Helvetica Neue', Arial, sans-serif;
                    font-variant-ligatures: normal; orphans: 2; widows:
                    2; background-color: rgb(252, 252, 252);" class=""><font
                      class="" color="#404040">This command can be used
                      to filter files entering trash directory based on
                      their size. Files above trash_max_filesize are
                      deleted/truncated directly.Value for size may be
                      followed by multiplicative suffixes as KB(=1024
                      bytes), MB(=1024*1024 bytes) and
                      GB(=1024*1024*1024 bytes). Default size is set to
                      5MB. Considering the fact that trash directory is
                      consuming the glusterfs volume space, trash
                      feature is implemented to function in such a way
                      that</font><b class=""> <font class=""
                        color="#ff4013">it directly deletes/truncates
                        files with size &gt; 1GB even if this option is
                        set to some value greater than 1GB.</font></b></div>
                </div>
                <div style="box-sizing: border-box; line-height: 24px;
                  margin: 0px; font-size: 16px; color: rgb(64, 64, 64);
                  font-family: Lato, proxima-nova, 'Helvetica Neue',
                  Arial, sans-serif; font-variant-ligatures: normal;
                  orphans: 2; widows: 2; background-color: rgb(252, 252,
                  252);" class=""><br class="">
                </div>
                <div style="box-sizing: border-box; line-height: 24px;
                  margin: 0px; font-variant-ligatures: normal; orphans:
                  2; widows: 2; background-color: rgb(252, 252, 252);"
                  class=""><span style="orphans: auto; widows: auto;"
                    class="">Is there any workaround (short of changing
                    source code and rebuilding) that can allow me to
                    override this 1GB hard limit?  We store a lot of
                    large files, and having a limit of 1GB greatly
                    reduces the value of this trashcan feature for us.</span></div>
                <div style="box-sizing: border-box; line-height: 24px;
                  margin: 0px; font-variant-ligatures: normal; orphans:
                  2; widows: 2; background-color: rgb(252, 252, 252);"
                  class=""><span style="orphans: auto; widows: auto;"
                    class=""><br class="">
                  </span></div>
              </blockquote>
              <br class="">
              <br class="">
              I don't remember exactly reason behind having a hard coded
              value for upper boundary, one reason may be to limit space
              used <br class="">
              by trash directory and for truncate operation it result in
              performance hit. The hard coded value can be found at <br
                class="">
              xlators/features/trash/src/trash.h:32
              (GF_ALLOWED_MAX_FILE_SIZE) . If you are interested , then
              change value(according to <br class="">
              your preference) in the code and send out a patch to <a
                moz-do-not-send="true" href="http://review.gluster.org/"
                class="">http://review.gluster.org/</a> as well.<br
                class="">
              <br class="">
              As first step please file a bug <a moz-do-not-send="true"
                href="https://bugzilla.redhat.com/" class="">https://bugzilla.redhat.com/</a>
              under community-&gt;glusterfs-&gt;trash xlator.<br
                class="">
              <br class="">
              Regards,<br class="">
              Jiffin<br class="">
              <br class="">
              <blockquote
                cite="mid:35E4CA0F-B0C3-4B70-B6FB-B34F133F8F4E@drive.ai"
                type="cite" class="">
                <div style="orphans: auto; widows: auto; box-sizing:
                  border-box; line-height: 24px; margin: 0px;
                  font-variant-ligatures: normal; background-color:
                  rgb(252, 252, 252);" class="">Many thanks,</div>
                <div style="orphans: auto; widows: auto; box-sizing:
                  border-box; line-height: 24px; margin: 0px;
                  font-variant-ligatures: normal; background-color:
                  rgb(252, 252, 252);" class="">Jackie</div>
                <div style="box-sizing: border-box; line-height: 24px;
                  margin: 0px; font-size: 16px; color: rgb(64, 64, 64);
                  font-family: Lato, proxima-nova, 'Helvetica Neue',
                  Arial, sans-serif; font-variant-ligatures: normal;
                  orphans: 2; widows: 2; background-color: rgb(252, 252,
                  252);" class=""><span style="font-family: Helvetica;
                    font-size: 12px; orphans: auto; widows: auto;"
                    class=""><br class="">
                  </span></div>
                <div style="box-sizing: border-box; line-height: 24px;
                  margin: 0px; font-size: 16px; color: rgb(64, 64, 64);
                  font-family: Lato, proxima-nova, 'Helvetica Neue',
                  Arial, sans-serif; font-variant-ligatures: normal;
                  orphans: 2; widows: 2; background-color: rgb(252, 252,
                  252);" class=""><br class="">
                </div>
                <div style="box-sizing: border-box; line-height: 24px;
                  margin: 0px; font-size: 16px; color: rgb(64, 64, 64);
                  font-family: Lato, proxima-nova, 'Helvetica Neue',
                  Arial, sans-serif; font-variant-ligatures: normal;
                  orphans: 2; widows: 2; background-color: rgb(252, 252,
                  252);" class=""><br class="">
                </div>
                <div style="box-sizing: border-box; line-height: 24px;
                  margin: 0px; font-size: 16px; color: rgb(64, 64, 64);
                  font-family: Lato, proxima-nova, 'Helvetica Neue',
                  Arial, sans-serif; font-variant-ligatures: normal;
                  orphans: 2; widows: 2; background-color: rgb(252, 252,
                  252);" class=""><br class="">
                </div>
                <br class="">
                <p class=""><font class="" color="#808080" size="1"
                    face="Courier New">The information in this email is
                    confidential and may be legally privileged. It is
                    intended solely for the addressee. Access to this
                    email by anyone else is unauthorized. If you are not
                    the intended recipient, any disclosure, copying,
                    distribution or any action taken or omitted to be
                    taken in reliance on it, is prohibited and may be
                    unlawful.</font></p>
                <br class="">
                <fieldset class="mimeAttachmentHeader"></fieldset>
                <br class="">
                <pre class="" wrap="">_______________________________________________
Gluster-users mailing list
<a moz-do-not-send="true" class="moz-txt-link-abbreviated" href="mailto:Gluster-users@gluster.org">Gluster-users@gluster.org</a>
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://www.gluster.org/mailman/listinfo/gluster-users">http://www.gluster.org/mailman/listinfo/gluster-users</a></pre>
              </blockquote>
              <br class="">
            </div>
          </div>
        </blockquote>
      </div>
      <br class="">
      <br>
      <p><font color="#808080" size="1" face="Courier New">The
          information in this email is confidential and may be legally
          privileged. It is intended solely for the addressee. Access to
          this email by anyone else is unauthorized. If you are not the
          intended recipient, any disclosure, copying, distribution or
          any action taken or omitted to be taken in reliance on it, is
          prohibited and may be unlawful.</font></p>
    </blockquote>
    <br>
  </body>
</html>