<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Oct 5, 2016 at 2:00 PM, Soumya Koduri <span dir="ltr"><<a href="mailto:skoduri@redhat.com" target="_blank">skoduri@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi,<br>
<br>
With <a href="http://review.gluster.org/#/c/15051/" rel="noreferrer" target="_blank">http://review.gluster.org/#/c/<wbr>15051/</a>, performace/client-io-threads is enabled by default. But with that we see regression caused to nfs-ganesha application trying to un/re-export any glusterfs volume. This shall be the same case with any gfapi application using glfs_fini().<br>
<br>
More details and the RCA can be found at [1].<br>
<br>
In short, iot-worker threads spawned (when the above option is enabled) are not cleaned up as part of io-threads-xlator->fini() and those threads could end up accessing invalid/freed memory post glfs_fini().<br>
<br>
The actual fix is to address io-threads-xlator->fini() to cleanup those threads before exiting. But since those threads' IDs are currently not stored, the fix could be very intricate and take a while. So till then to avoid all existing applications crash, I suggest to keep this option disabled by default and update this known_issue with enabling this option in the release-notes.<br>
<br>
I sent a patch to revert the commit - <a href="http://review.gluster.org/#/c/15616/" rel="noreferrer" target="_blank">http://review.gluster.org/#/c/<wbr>15616/</a> [2]<br></blockquote><div><br></div><div>Good catch! I think the correct fix would be to make sure all threads die as part of PARENT_DOWN then?<br><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Comments/Suggestions are welcome.<br>
<br>
Thanks,<br>
Soumya<br>
<br>
[1] <a href="https://bugzilla.redhat.com/show_bug.cgi?id=1380619#c11" rel="noreferrer" target="_blank">https://bugzilla.redhat.com/sh<wbr>ow_bug.cgi?id=1380619#c11</a><br>
[2] <a href="http://review.gluster.org/#/c/15616/" rel="noreferrer" target="_blank">http://review.gluster.org/#/c/<wbr>15616/</a><br>
</blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">Pranith<br></div></div>
</div></div>