Hari,<div><br></div><div>I think you misunderstood my statement, probably I shouldn't have mentioned existing semantics. One eg here should clarify it, so this is what I propose:<span></span></div><div><br></div><div>gluster v tier <volname> remove-brick tier-type hot <bricks> start</div><div><br></div><div>Note that my request was to add an argument i.e tier-type here. </div><div><br><br>On Monday 3 October 2016, Hari Gowtham <<a href="mailto:hgowtham@redhat.com">hgowtham@redhat.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Atin,<br>
Yes, we can do it. the existing semantics need some changes because of the<br>
attach tier command (gluster volume tier <VOLNAME> attach <BRICK>...) the<br>
parsing has to be changed to accommodate the attach tier command. if used as I<br>
mentioned then we can use the functions of attach tier generic for adding brick<br>
also. Other thing with using args is. it needs changes to support the keywords<br>
like replica <count> also. so when we try to make a generic function for add<br>
brick on tiered volume and attach tier these keywords like replica <count> and<br>
tier-type <hot/cold> will need more changes.<br>
<br>
So i feel its better to have a separate command instead of the args.<br>
If i have been missing any pros from having the args let me know.<br>
<br>
----- Original Message -----<br>
> From: "Atin Mukherjee" <<a href="javascript:;" onclick="_e(event, 'cvml', 'amukherj@redhat.com')">amukherj@redhat.com</a>><br>
> To: "Hari Gowtham" <<a href="javascript:;" onclick="_e(event, 'cvml', 'hgowtham@redhat.com')">hgowtham@redhat.com</a>><br>
> Cc: "gluster-devel" <<a href="javascript:;" onclick="_e(event, 'cvml', 'gluster-devel@gluster.org')">gluster-devel@gluster.org</a>>, "gluster-users" <<a href="javascript:;" onclick="_e(event, 'cvml', 'gluster-users@gluster.org')">gluster-users@gluster.org</a>><br>
> Sent: Monday, October 3, 2016 2:31:40 PM<br>
> Subject: Re: [Gluster-devel] New commands for supporting add/remove brick and rebalance on tiered volume<br>
><br>
> On Mon, Oct 3, 2016 at 12:21 PM, Hari Gowtham <<a href="javascript:;" onclick="_e(event, 'cvml', 'hgowtham@redhat.com')">hgowtham@redhat.com</a>> wrote:<br>
><br>
> > Hi,<br>
> ><br>
> > The current add and remove brick commands aren't sufficient to support<br>
> > add/remove brick on tiered volumes.So the commands need minor changes<br>
> > like mentioning which tier we are doing the operation on. So in order<br>
> > to specify the tier on which we are performing the changes, I thought<br>
> > of using the following commands for add and remove brick<br>
> ><br>
> > adding brick on tiered volume:<br>
> > gluster volume tier <volname> add-hot-brick/add-cold-brick <brick> ...<br>
> > <force><br>
> ><br>
> > removing brick on tierd volume:<br>
> > gluster volume tier <volname> remove-hot-brick/remove-cold-<wbr>brick <brick><br>
> > ... <start|stop|status|commit|<wbr>force><br>
> ><br>
> > I have framed it this way because once we mention details about tiering<br>
> > these commands become specific to tier and the syntax that we follow for<br>
> > commands are gluster volume component <VOLNAME> ...<br>
> > So i have made sure that the keyword tier comes after volume.<br>
> > Need suggestions to make these commands better.<br>
> ><br>
> > Similarly once we support add/remove brick we will be having rebalance<br>
> > commands and the idea is to support rebalance separately for each tier.<br>
> > So once we will have to rebalance status to display for which we need<br>
> > rebalance commands specific to tier. so these are the commands we have<br>
> > thought of:<br>
> > gluster v tier <VOLNAME> hot-rebalance/cold-rebalance <start|stop|status><br>
> ><br>
> > Need your comments regarding this.<br>
> ><br>
><br>
> Overall it makes sense. Just a comment here. Instead of mentioning<br>
> remove/add/rebalance-hot/cold-<wbr>brick can we have an additional arg called<br>
> tier-type <hot/cold> and continue with the existing semantics like<br>
> remove-brick, add-brick and rebalance?<br>
><br>
><br>
> > --<br>
> > Regards,<br>
> > Hari.<br>
> ><br>
> > ______________________________<wbr>_________________<br>
> > Gluster-devel mailing list<br>
> > <a href="javascript:;" onclick="_e(event, 'cvml', 'Gluster-devel@gluster.org')">Gluster-devel@gluster.org</a><br>
> > <a href="http://www.gluster.org/mailman/listinfo/gluster-devel" target="_blank">http://www.gluster.org/<wbr>mailman/listinfo/gluster-devel</a><br>
> ><br>
><br>
><br>
><br>
> --<br>
><br>
> --Atin<br>
><br>
<br>
--<br>
Regards,<br>
Hari.<br>
<br>
</blockquote></div><br><br>-- <br>--Atin<br>