<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
<br>
<div class="moz-cite-prefix">On 04/19/2016 12:41 PM, Krutika
Dhananjay wrote:<br>
</div>
<blockquote
cite="mid:CAPhYV8NCw6KNRTwm-0fasDUkanT3XCN_v2b0WrvA3PjxpnqHQg@mail.gmail.com"
type="cite">
<div dir="ltr"><br>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Tue, Apr 19, 2016 at 5:30 AM,
Lindsay Mathieson <span dir="ltr"><<a
moz-do-not-send="true"
href="mailto:lindsay.mathieson@gmail.com"
target="_blank">lindsay.mathieson@gmail.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"> Is it possible to
confirm the following understandings on my part?<br>
<br>
<br>
- heal info shows the list of files with uncommitted
writes across the bricks that would need heals <b><span>*</span>if<span>*</span></b>
a brick went down before the write was committed. <br>
</div>
</blockquote>
<div><br>
</div>
<div>Yes and no. So heal-info reports both files that truly
need heal and those that are currently participating in an
uncommitted transaction. The latter entries are reported
as "possible undergoing heal". I believe we are going to
drop the latter category of entries going forward. IIUC
Pranith is working on something that does that. But I will
let him confirm that.<br>
</div>
</div>
</div>
</div>
</blockquote>
<br>
Lindsay,<br>
Heal info must show all the files/dirs that require heal.
At the moment there is a bug where it says 'possibly undergoing
heal' even when the file doesn't need heal, for which we sent a fix
<a class="moz-txt-link-freetext" href="http://review.gluster.org/13873">http://review.gluster.org/13873</a>, this is undergoing review and
should be available in next releases. Once this is in, Your
understanding is correct. Only thing to add is, the write may fail
with either brick going down or any other error too like ENOSPACE
etc.<br>
<br>
Pranith<br>
<br>
<blockquote
cite="mid:CAPhYV8NCw6KNRTwm-0fasDUkanT3XCN_v2b0WrvA3PjxpnqHQg@mail.gmail.com"
type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<div><br>
</div>
<div> </div>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div> * additionally it lists files being healed if a
heal is in process <br>
* writes can be data and metadata. <br>
<br>
</div>
</blockquote>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"> <br>
- statics heal-count shows the count of files <b><span>*</span>actually
needing healing<span>*</span></b></div>
</blockquote>
<div><br>
</div>
<div>This is correct for the most part. The only remote case
where it will not report pending heals when it is supposed
to is if some entries were marked "dirty" (indicated by
the presence of their index under
.glusterfs/indices/dirty). So it only considers count of
entries needing heal in .glusterfs/indices/xattrop but not
.glusterfs/indices/dirty.<br>
<br>
</div>
<div>For what it's worth, I realised that we don't really
need to use locks to examine whether files need heal or
not if the entries are under indices/xattrop. So if there
is an entry under .glusterfs/indices/xattrop, it means it
definitely needs heal. Only the entries under
.glusterfs/indices/dirty need careful inspection. This
will significantly enhance heal-info response time. So I
will<br>
</div>
<div>work on getting this change in, maybe for the next .x
release.<br>
</div>
</div>
</div>
</div>
</blockquote>
<br>
I think with Krutika's fix heal info will be super fast compared to
what we have now. Please use heal info. If there are any bugs we
will fix them, it handles all corner cases.<br>
<br>
Pranith<br>
<blockquote
cite="mid:CAPhYV8NCw6KNRTwm-0fasDUkanT3XCN_v2b0WrvA3PjxpnqHQg@mail.gmail.com"
type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<div><br>
</div>
<div>-Krutika<br>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"> <br>
<br>
<br>
<br>
<br>
So its perfectly ok to see files being listed by heal
info on a busy cluster, so long as they aren't marked as
a heal in progress. <br>
<br>
<br>
thanks ,<span class="HOEnZb"><font color="#888888"><br>
<pre cols="72">--
Lindsay Mathieson</pre>
</font></span></div>
<br>
_______________________________________________<br>
Gluster-users mailing list<br>
<a moz-do-not-send="true"
href="mailto:Gluster-users@gluster.org">Gluster-users@gluster.org</a><br>
<a moz-do-not-send="true"
href="http://www.gluster.org/mailman/listinfo/gluster-users"
rel="noreferrer" target="_blank">http://www.gluster.org/mailman/listinfo/gluster-users</a><br>
</blockquote>
</div>
<br>
</div>
</div>
</blockquote>
<br>
</body>
</html>