<p dir="ltr"></p>
<p dir="ltr">Sent from one plus one<br>
On Jun 17, 2015 10:10 PM, "Pranith Kumar Karampuri" <<a href="mailto:pkarampu@redhat.com">pkarampu@redhat.com</a>> wrote:<br>
><br>
><br>
><br>
> On 06/17/2015 09:28 PM, Ravishankar N wrote:<br>
>><br>
>> Hello,<br>
>><br>
>> I sent a patch [1] to print the backtrace generated by 'gf_log_callingfn' (only) in a human-readable way. While it improves readability by printing every function of the backtrace in a separate line (which is how a backtrace *should* look), it violates the fact that every log in gluster gets logged in a single line. Does anyone see any problem with this? Especially sys-admins who might have scripts/ mechanisms to parse logs? Note that the patch affects only messages logged using gf_log_callingfn() and is avoids eyesore.<br>
><br>
> Grepping logs will be difficult with this change. May be we can use something like:<br>
> sed 's/(-->/\n(-->/g' <logfile.log> to achieve the same?<br>
It doesn't bother me too much if some changes are required in applying filters, you will need this change if you try to improve readability. Being a developer sometimes I get confused with this log, at least its not readable. I would like to see this change in (I am yet to review it though).<br>
><br>
> Pranith<br>
><br>
>><br>
>> Thanks,<br>
>> Ravi<br>
>><br>
>><br>
>> [1] <a href="http://review.gluster.org/#/c/11217/1">http://review.gluster.org/#/c/11217/1</a><br>
>> _______________________________________________<br>
>> Gluster-users mailing list<br>
>> <a href="mailto:Gluster-users@gluster.org">Gluster-users@gluster.org</a><br>
>> <a href="http://www.gluster.org/mailman/listinfo/gluster-users">http://www.gluster.org/mailman/listinfo/gluster-users</a><br>
><br>
><br>
> _______________________________________________<br>
> Gluster-users mailing list<br>
> <a href="mailto:Gluster-users@gluster.org">Gluster-users@gluster.org</a><br>
> <a href="http://www.gluster.org/mailman/listinfo/gluster-users">http://www.gluster.org/mailman/listinfo/gluster-users</a><br>
</p>