<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Apr 2, 2015 at 10:28 PM, Kaushal M <span dir="ltr"><<a href="mailto:kshlmster@gmail.com" target="_blank">kshlmster@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">On Thu, Apr 2, 2015 at 7:20 PM, Kelvin Edmison<br>
<<a href="mailto:kelvin.edmison@alcatel-lucent.com">kelvin.edmison@alcatel-lucent.com</a>> wrote:<br>
> Gaurav,<br>
><br>
> I think that it is appropriate to keep the commit force options for<br>
> replace-brick, just to prevent less experienced admins from self-inflicted<br>
> data loss scenarios.<br>
><br>
> The add-brick/remove-brick pair of operations is not an intuitive choice for<br>
> admins who are trying to solve a problem with a specific brick. In this<br>
> situation, admins are generally thinking 'how can I move the data from this<br>
> brick to another one', and an admin that is casually surfing documentation<br>
> might infer that the replace-brick operation is the correct one, rather than<br>
> a sequence of commands that are somehow magically related.<br>
><br>
> I believe that keeping the mandatory commit force options for replace-brick<br>
> will help give these admins reason to pause and re-consider if this is the<br>
> right command for them to do, and prevent cases where new gluster admins<br>
> start shouting 'gluster lost my data'.<br>
><br>
> Regards,<br>
> Kelvin<br>
><br>
><br>
><br>
> On 04/02/2015 07:26 AM, Gaurav Garg wrote:<br>
>><br>
>> Hi all,<br>
>><br>
>> Since GlusterFs version 3.6.0 "gluster volume replace-brick <VOLNAME><br>
>> <SOURCE-BRICK> <NEW-BRICK> {start [force]|pause|abort|status|commit }"<br>
>> command have deprecated. Only "gluster volume replace-brick <VOLNAME><br>
>> <SOURCE-BRICK> <NEW-BRICK> commit force" command supported.<br>
>><br>
>> for bug <a href="https://bugzilla.redhat.com/show_bug.cgi?id=1094119" target="_blank">https://bugzilla.redhat.com/show_bug.cgi?id=1094119</a> , Patch<br>
>> <a href="http://review.gluster.org/#/c/10101/" target="_blank">http://review.gluster.org/#/c/10101/</a> is removing cli/glusterd code for<br>
>> "gluster volume replace-brick <VOLNAME> <BRICK> <NEW-BRICK> {start<br>
>> [force]|pause|abort|status|commit }" command. so only we have commit force<br>
>> option supported for replace-brick command.<br>
>><br>
>> Should we have new command "gluster volume replace-brick <VOLNAME><br>
>> <SOURCE-BRICK> <NEW-BRICK>" instead of having "gluster volume replace-brick<br>
>> <VOLNAME> <SOURCE-BRICK> <NEW-BRICK> commit force" command.<br>
>><br>
>><br>
>> Thanks & Regards<br>
>> Gaurav Garg<br>
>> _______________________________________________<br>
>> Gluster-users mailing list<br>
>> <a href="mailto:Gluster-users@gluster.org">Gluster-users@gluster.org</a><br>
>> <a href="http://www.gluster.org/mailman/listinfo/gluster-users" target="_blank">http://www.gluster.org/mailman/listinfo/gluster-users</a><br>
><br>
><br>
><br>
><br>
> _______________________________________________<br>
> Gluster-users mailing list<br>
> <a href="mailto:Gluster-users@gluster.org">Gluster-users@gluster.org</a><br>
> <a href="http://www.gluster.org/mailman/listinfo/gluster-users" target="_blank">http://www.gluster.org/mailman/listinfo/gluster-users</a><br>
<br>
</div></div>AFAIK, it was never the plan to remove 'replace-brick commit force'.<br>
The plan was always to retain it while removing the unsupported and<br>
unneeded options, ie 'replace-brick (start|pause|abort|status)'.<br>
<br>
Gaurav, your change is attempting to do the correct thing already and<br>
needs no changes (other than any that arise via the review process).<br>
<span class="HOEnZb"><font color="#888888"><br></font></span></blockquote><div><br></div><div>I agree with Kelvin and Kaushal.</div><div>We should retain "commit force"; "force" brings the implicit meaning</div><div>that I fully understand what I am asking to be done is not the norm,</div><div>but do proceed and I hold myself responsible for anything bad that</div><div>happens.</div><div><br></div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="HOEnZb"><font color="#888888">
~kaushal<br>
</font></span><div class="HOEnZb"><div class="h5">_______________________________________________<br>
Gluster-users mailing list<br>
<a href="mailto:Gluster-users@gluster.org">Gluster-users@gluster.org</a><br>
<a href="http://www.gluster.org/mailman/listinfo/gluster-users" target="_blank">http://www.gluster.org/mailman/listinfo/gluster-users</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr"><font color="#666666"><b>Raghavendra Talur </b></font><div><br></div></div></div>
</div></div>