<p dir="ltr"><br>
On 5 Apr 2016 3:43 p.m., "Kaushal M" <<a href="mailto:kshlmster@gmail.com">kshlmster@gmail.com</a>> wrote:<br>
><br>
> So gerrit voting seems to be working again. It required all the jobs<br>
> to have the same trigger configuration.<br>
><br>
> Smoke vote was given for [1] a test change that I posted for review.<br>
> Now just need to check if it works for changes which already have<br>
> regressions run on them.<br>
> I'll be following [2] to see it works.</p>
<p dir="ltr">Working now. If anyone notices anything amiss, please let gluster-infra know of it. </p>
<p dir="ltr">><br>
> [1] <a href="https://review.gluster.org/13898">https://review.gluster.org/13898</a><br>
> [2] <a href="https://review.gluster.org/13869">https://review.gluster.org/13869</a><br>
><br>
> On Tue, Apr 5, 2016 at 12:46 PM, Prasanna Kalever <<a href="mailto:pkalever@redhat.com">pkalever@redhat.com</a>> wrote:<br>
> > On Tue, Apr 5, 2016 at 12:39 PM, Kaushal M <<a href="mailto:kshlmster@gmail.com">kshlmster@gmail.com</a>> wrote:<br>
> >> On Tue, Apr 5, 2016 at 11:26 AM, Kaushal M <<a href="mailto:kshlmster@gmail.com">kshlmster@gmail.com</a>> wrote:<br>
> >>> On Tue, Apr 5, 2016 at 11:10 AM, Atin Mukherjee <<a href="mailto:amukherj@redhat.com">amukherj@redhat.com</a>> wrote:<br>
> >>>><br>
> >>>><br>
> >>>> On 04/05/2016 11:06 AM, Kaushal M wrote:<br>
> >>>>> I did some changes so that all smoke jobs (linux, *bsd smoke jobs,<br>
> >>>>> devrpm jobs etc) are triggered for `recheck smoke`.<br>
> >>>>><br>
> >>>>> The collated results are being reported back and the 'Smoke' flag is<br>
> >>>>> being set. But sometimes, if regression jobs have been already run on<br>
> >>>>> the patchset, jenkins is collating those results as well.<br>
> >>>>> When this happens, a '-Verified' flag is being set.<br>
> >>>>><br>
> >>>>> Jenkins and its gerrit plugin collate results for jobs launched by the<br>
> >>>>> same event. The regression and smoke jobs should be triggered for<br>
> >>>>> different events,<br>
> >>>>> but for some reason jenkins is assuming that they're being triggered<br>
> >>>>> by the same event and collating all of them together.<br>
> >>>>><br>
> >>>>> I need some time to figure out why this is happening, and fix it.<br>
> >>>> Is there a way that this doesn't impact the merging as until we get all<br>
> >>>> the positive votes, web interface doesn't provide a submit button.<br>
> >>><br>
> >>> This would require manually running the gerrit ssh command as the<br>
> >>> build user to set the flag, which requires sudo access on<br>
> >>> <a href="http://build.gluster.org">build.gluster.org</a>.<br>
> >><br>
> >> Alternatively, administrators can spoof other users. Administrators can do<br>
> >> `ssh <username>@<a href="http://review.gluster.org">review.gluster.org</a> suexec --as<br>
> >> <a href="mailto:jenkins@build.gluster.org">jenkins@build.gluster.org</a> -- gerrit review --label Smoke=+1<br>
> >> <patch>,<patchset>`<br>
> ><br>
> > As Kaushal mentioned above<br>
> ><br>
> > 1. users are free to comment "recheck smoke" (which will trigger smoke)<br>
> > 2. only after success on step 1, administrators will get +1 done with 'ssh ...'<br>
> ><br>
> ><br>
> > Thanks,<br>
> > --<br>
> > Prasanna<br>
> ><br>
> ><br>
> ><br>
> >><br>
> >> I'm still figuring out how to solve it properly though.<br>
> >><br>
> >>><br>
> >>><br>
> >>>>><br>
> >>>>> ~kaushal<br>
> >>>>><br>
> >>>>><br>
> >>>>> On Mon, Apr 4, 2016 at 10:39 PM, Prasanna Kalever <<a href="mailto:pkalever@redhat.com">pkalever@redhat.com</a>> wrote:<br>
> >>>>>> On Mon, Apr 4, 2016 at 9:58 PM, Atin Mukherjee<br>
> >>>>>> <<a href="mailto:atin.mukherjee83@gmail.com">atin.mukherjee83@gmail.com</a>> wrote:<br>
> >>>>>>> Did anyone notice that for few of the patches smoke results are not voted<br>
> >>>>>>> back?<br>
> >>>>>>><br>
> >>>>>>> <a href="http://review.gluster.org/#/c/13869">http://review.gluster.org/#/c/13869</a> is one of them.<br>
> >>>>>><br>
> >>>>>> +1<br>
> >>>>>><br>
> >>>>>> Here is another one <a href="http://review.gluster.org/#/c/11083/">http://review.gluster.org/#/c/11083/</a><br>
> >>>>>> I have also re-triggered it with "recheck smoke", after which<br>
> >>>>>> it return success "<a href="http://build.gluster.org/job/smoke/26373/">http://build.gluster.org/job/smoke/26373/</a> : SUCCESS"<br>
> >>>>>><br>
> >>>>>> but again failed to report back ...<br>
> >>>>>><br>
> >>>>>> --<br>
> >>>>>> Prasanna<br>
> >>>>>><br>
> >>>>>><br>
> >>>>>>><br>
> >>>>>>> -Atin<br>
> >>>>>>> Sent from one plus one<br>
> >>>>>>><br>
> >>>>>>><br>
> >>>>>>> _______________________________________________<br>
> >>>>>>> Gluster-infra mailing list<br>
> >>>>>>> <a href="mailto:Gluster-infra@gluster.org">Gluster-infra@gluster.org</a><br>
> >>>>>>> <a href="http://www.gluster.org/mailman/listinfo/gluster-infra">http://www.gluster.org/mailman/listinfo/gluster-infra</a><br>
> >>>>>> _______________________________________________<br>
> >>>>>> Gluster-devel mailing list<br>
> >>>>>> <a href="mailto:Gluster-devel@gluster.org">Gluster-devel@gluster.org</a><br>
> >>>>>> <a href="http://www.gluster.org/mailman/listinfo/gluster-devel">http://www.gluster.org/mailman/listinfo/gluster-devel</a><br>
> >>>>> _______________________________________________<br>
> >>>>> Gluster-devel mailing list<br>
> >>>>> <a href="mailto:Gluster-devel@gluster.org">Gluster-devel@gluster.org</a><br>
> >>>>> <a href="http://www.gluster.org/mailman/listinfo/gluster-devel">http://www.gluster.org/mailman/listinfo/gluster-devel</a><br>
> >>>>><br>
</p>