<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Hi Raghavendra,<br>
<br>
Can we have this documented (with a example workflow) here: <br>
<a class="moz-txt-link-freetext" href="http://gluster.readthedocs.org/en/latest/Developer-guide/Development-Workflow/">http://gluster.readthedocs.org/en/latest/Developer-guide/Development-Workflow/</a><br>
<br>
Thanks,<br>
Saravana <br>
<br>
<div class="moz-cite-prefix">On 03/07/2016 10:57 AM, Raghavendra
Talur wrote:<br>
</div>
<blockquote
cite="mid:CAM5jxn80Yb1re55GZwb9ROTTv=35ZhmhbHjAjB-2X4Teo2G6xQ@mail.gmail.com"
type="cite">
<div dir="ltr"><br>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Fri, Mar 4, 2016 at 6:13 PM,
Raghavendra Talur <span dir="ltr"><<a
moz-do-not-send="true" href="mailto:rtalur@redhat.com"
target="_blank"><a class="moz-txt-link-abbreviated" href="mailto:rtalur@redhat.com">rtalur@redhat.com</a></a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr"><br>
<div class="gmail_extra"><br>
<div class="gmail_quote"><span class="">On Thu, Feb 4,
2016 at 7:13 PM, Niels de Vos <span dir="ltr"><<a
moz-do-not-send="true"
href="mailto:ndevos@redhat.com"
target="_blank"><a class="moz-txt-link-abbreviated" href="mailto:ndevos@redhat.com">ndevos@redhat.com</a></a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0
0 .8ex;border-left:1px #ccc
solid;padding-left:1ex"><span>On Thu, Feb 04,
2016 at 04:15:16PM +0530, Raghavendra Talur
wrote:<br>
> On Thu, Feb 4, 2016 at 4:13 PM, Niels de
Vos <<a moz-do-not-send="true"
href="mailto:ndevos@redhat.com"
target="_blank">ndevos@redhat.com</a>>
wrote:<br>
><br>
> > On Thu, Feb 04, 2016 at 03:34:05PM
+0530, Raghavendra Talur wrote:<br>
> > > Hi,<br>
> > ><br>
> > > We recently changed the jenkins
builds to be triggered on the following<br>
> > > triggers.<br>
> > ><br>
> > > 1. Verified+1<br>
> > > 2. Code-review+2<br>
> > > 3. recheck
(netbsd|centos|smoke)<br>
> > ><br>
> > > There is a bug in 1 and 2.<br>
> > ><br>
> > > Multiple triggers of 1 or 2
would result in re-runs even when not<br>
> > intended.<br>
> > ><br>
> > > I would like to replace 1 and 2
with a comment "run-all-regression" or<br>
> > > something like that.<br>
> > > Thoughts?<br>
> ><br>
> > Maybe starting regressions on
Code-Review +1 (or +2) only?<br>
> ><br>
><br>
> Multiple code-reviews would do multiple
triggers. Won't work.<br>
<br>
</span>How can we make this to work, without the
need of providing magic<br>
comments?<br>
</blockquote>
<div><br>
</div>
</span>
<div>I investigated but couldn't find a way to make
it work. Discussed with Kaushal and we feel it
should be ok to go with a "check all" comment for
initial regression run and deprecate Code-Review+2
and Verified+1 triggers.</div>
<div><br>
</div>
<div>I would like to go ahead and do it as the build
queue is increasing again just because of
Code-Review+2's given just before a patch is
merged; they don't serve any purpose.</div>
</div>
</div>
</div>
</blockquote>
<div><br>
</div>
<div>I have for now just removed trigger for code-review.</div>
<div>Trigger for verified+1 remains as is.</div>
<div>No new trigger on comments have been added.</div>
<div><br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<span><font color="#888888"><br>
Niels<br>
</font></span></blockquote>
</div>
<br>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
Gluster-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Gluster-devel@gluster.org">Gluster-devel@gluster.org</a>
<a class="moz-txt-link-freetext" href="http://www.gluster.org/mailman/listinfo/gluster-devel">http://www.gluster.org/mailman/listinfo/gluster-devel</a></pre>
</blockquote>
<br>
</body>
</html>