<html>
<head>
<meta http-equiv="content-type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<tt>'brick_up_status' is used by the following .ts in release-3.7</tt><tt><br>
</tt><tt><br>
</tt><tt>[root@ravi1 glusterfs]# git grep -w brick_up_status</tt><tt><br>
</tt><tt><br>
</tt><tt>tests/bugs/bitrot/bug-1288490.t:EXPECT_WITHIN
$PROCESS_UP_TIMEOUT "Y" brick_up_status $V0 $H0 $B0/brick0</tt><tt><br>
</tt><tt>tests/bugs/bitrot/bug-1288490.t:EXPECT_WITHIN
$PROCESS_UP_TIMEOUT "Y" brick_up_status $V0 $H0 $B0/brick1</tt><tt><br>
</tt><tt>tests/bugs/glusterd/bug-1225716-brick-online-validation-remove-brick.t:EXPECT_WITHIN
$PROCESS_UP_TIMEOUT "Y" brick_up_status $V0 $H0 $B0/${V0}1</tt><tt><br>
</tt><tt>tests/bugs/glusterd/bug-857330/normal.t:EXPECT_WITHIN
$PROCESS_UP_TIMEOUT "Y" brick_up_status $V0 $H0 $B0/${V0}3</tt><tt><br>
</tt><tt>tests/bugs/glusterd/bug-857330/xml.t:EXPECT_WITHIN
$PROCESS_UP_TIMEOUT "Y" brick_up_status $V0 $H0 $B0/${V0}3</tt><tt><br>
</tt><tt><br>
</tt><tt>There seems to be a bug in this function. (It is another
matter that the function is different in master but let us ignore
that for now). So all these tests should fail on release-3.7 and
they do fail on my machine.</tt><b><tt>But for some reason, they
succeed on jenkins. Why is that? They are not in bad_tests on
3.7 either.</tt></b><b><tt><br>
</tt></b><tt><br>
</tt><tt>This fixes the function:</tt><tt><br>
</tt><font color="#000099"><tt>diff --git a/tests/volume.rc
b/tests/volume.rc</tt><tt><br>
</tt><tt>index 9bd9eca..6040c5f 100644</tt><tt><br>
</tt><tt>--- a/tests/volume.rc</tt><tt><br>
</tt><tt>+++ b/tests/volume.rc</tt><tt><br>
</tt><tt>@@ -24,7 +24,7 @@ function brick_up_status {</tt><tt><br>
</tt><tt> local host=$2</tt><tt><br>
</tt><tt> local brick=$3</tt><tt><br>
</tt><tt> brick_pid=$(get_brick_pid $vol $host $brick)</tt><tt><br>
</tt><tt>- gluster volume status | grep $brick_pid | awk
'{print $4}'</tt><tt><br>
</tt><tt>+ gluster volume status | grep $brick_pid | awk
'{print $5}'</tt><tt><br>
</tt><tt> }</tt></font><tt><br>
</tt><tt> </tt><tt><br>
</tt><tt>and all the tests pass with the fix on my machine. I had
send the fix as a part of a patch[1] and it *fails* on jenkins.</tt><tt>
Why?<br>
<br>
Thanks,<br>
Ravi<br>
<br>
<br>
[1] <a class="moz-txt-link-freetext" href="http://review.gluster.org/#/c/13609/2">http://review.gluster.org/#/c/13609/2</a><br>
</tt><tt><br>
</tt><tt><br>
</tt><br>
</body>
</html>