<html>
  <head>
    <meta content="text/html; charset=utf-8" http-equiv="Content-Type">
  </head>
  <body text="#000000" bgcolor="#FFFFFF">
    <div class="moz-cite-prefix">Hi, <br>
      <br>
      We can have a discussion tomorrow i.e 12th January from 3pm to 4
      pm. Does that time work for you?<br>
      <br>
      Meeting Link : <span><span><span><a moz-do-not-send="true"
href="https://www.google.com/url?q=https%3A%2F%2Fbluejeans.com%2Fu%2Fasengupt%2F&amp;sa=D&amp;usd=2&amp;usg=AFQjCNHgp0xCwA9DqgdbAc9s2OxthUEHRA">https://bluejeans.com/u/asengu<wbr>pt/</a></span></span></span><br>
      <br>
      Regards,<br>
      Avra<br>
      <br>
      On 01/10/2017 09:35 PM, <a class="moz-txt-link-abbreviated" href="mailto:sriram@marirs.net.in">sriram@marirs.net.in</a> wrote:<br>
    </div>
    <blockquote
cite="mid:1484064341.4190267.843233153.755E0769@webmail.messagingengine.com"
      type="cite">
      <title></title>
      <div>Hello Rajesh, Avra, <br>
      </div>
      <div><br>
      </div>
      <div>Could we have a discussion on the below? This week sometime?
        <br>
      </div>
      <div><br>
      </div>
      <div>Sriram<br>
      </div>
      <div><br>
      </div>
      <div><br>
      </div>
      <div>On Mon, Jan 2, 2017, at 04:56 PM, Rajesh Joseph wrote:<br>
      </div>
      <blockquote type="cite">
        <div dir="ltr">
          <div>
            <div>Sure, will setup it from next week onward.<br>
            </div>
          </div>
          <div>-Rajesh<br>
          </div>
        </div>
        <div>
          <div><br>
          </div>
          <div defang_data-gmailquote="yes">
            <div>On Mon, Jan 2, 2017 at 4:38 PM, <span dir="ltr">&lt;<a
                  moz-do-not-send="true"
                  href="mailto:sriram@marirs.net.in"><a class="moz-txt-link-abbreviated" href="mailto:sriram@marirs.net.in">sriram@marirs.net.in</a></a>&gt;</span>
              wrote:<br>
            </div>
            <blockquote defang_data-gmailquote="yes"
              style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,
              204, 204);padding-left:1ex;">
              <div><br>
              </div>
              <div>
                <div>Hi Rajesh, <br>
                </div>
                <div><br>
                </div>
                <div>Right now bi-weekly should be ok, with progress we
                  could decide. I'll continue to rework the initial
                  patch set and post it for review. We'll take it from
                  there, is that ok with you? <br>
                </div>
                <div><br>
                </div>
                <div>Sriram <br>
                </div>
                <div>
                  <div>
                    <div><br>
                    </div>
                    <div><br>
                    </div>
                    <div>On Mon, Jan 2, 2017, at 03:32 PM, Rajesh Joseph
                      wrote:<br>
                    </div>
                    <blockquote type="cite">
                      <div dir="ltr">
                        <div><br>
                        </div>
                        <div>
                          <div><br>
                          </div>
                          <div>
                            <div>On Mon, Jan 2, 2017 at 3:19 PM, <span
                                dir="ltr">&lt;<a moz-do-not-send="true"
                                  href="mailto:sriram@marirs.net.in">sriram@marirs.net.in</a>&gt;</span>
                              wrote:<br>
                            </div>
                            <blockquote
                              style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,
                              204, 204);padding-left:1ex;">
                              <div><br>
                              </div>
                              <div>
                                <div>Hi Avra, <br>
                                </div>
                                <div><br>
                                </div>
                                <div>Is the below request ok with you? <br>
                                </div>
                                <div><br>
                                </div>
                                <div>Sriram<br>
                                </div>
                                <div><br>
                                </div>
                                <div><br>
                                </div>
                                <div>On Wed, Dec 21, 2016, at 10:00 AM,
                                  <a moz-do-not-send="true"
                                    href="mailto:sriram@marirs.net.in">sriram@marirs.net.in</a>
                                  wrote:<br>
                                </div>
                                <blockquote type="cite">
                                  <div>Hi Avra/Rajesh, <br>
                                  </div>
                                  <div><br>
                                  </div>
                                  <div>In continuation to the discussion
                                    we'd yesterday, I'd be working on
                                    the change we'd initiated sometime
                                    back for pluggable FS specific
                                    snapshot implementation. We'd be
                                    moving our gluster deployements to
                                    "master" (stable) once this feature
                                    goes in. Since, glusterd2.0 release
                                    is scheduled release next year, I'd
                                    be happy if some of the work done
                                    here is re-usable to glusterd2.0 as
                                    well. <br>
                                  </div>
                                  <div><br>
                                  </div>
                                  <div>Let me know, if this is ok. Like
                                    Rajesh mentioned in the call, could
                                    we've a weekly meeting for the same
                                    feature? <br>
                                  </div>
                                </blockquote>
                              </div>
                            </blockquote>
                            <div><br>
                            </div>
                            <div>
                              <div>Hi Sriram,<br>
                              </div>
                            </div>
                            <div>
                              <div>I was on vacation so could not reply
                                to your mail.<br>
                              </div>
                            </div>
                            <div>
                              <div>I am OK with having a regular sync-up
                                on this issue. Let's take this to
                                conclusion.<br>
                              </div>
                              <div>Do we need a weekly meeting or
                                bi-weekly meeting is fine?<br>
                              </div>
                            </div>
                            <div>Best Regards,<br>
                            </div>
                            <div>Rajesh<br>
                            </div>
                            <div>
                              <div><br>
                              </div>
                              <div> <br>
                              </div>
                            </div>
                            <blockquote
                              style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,
                              204, 204);padding-left:1ex;">
                              <div>
                                <blockquote type="cite">
                                  <div><br>
                                  </div>
                                  <div><br>
                                  </div>
                                  <div>Sriram<br>
                                  </div>
                                  <div><br>
                                  </div>
                                  <div>On Mon, Dec 19, 2016, at 03:55
                                    PM, <a moz-do-not-send="true"
                                      href="mailto:asengupt@redhat.com">asengupt@redhat.com</a>
                                    wrote:<br>
                                  </div>
                                  <blockquote type="cite">
                                    <div><span><span
                                          style="display:none;"></span><span></span></span><br>
                                    </div>
                                    <div><span><span>
                                          <table summary=""
                                            style="width:100%;font-family:Arial,sans-serif;border-top-style:solid;border-right-style:solid;border-bottom-style:solid;border-left-style:solid;border-top-color:rgb(204,
                                            204,
                                            204);border-right-color:rgb(204,
                                            204,
                                            204);border-bottom-color:rgb(204,
                                            204,
                                            204);border-left-color:rgb(204,
                                            204,
                                            204);border-top-width:1px;border-right-width:2px;border-bottom-width:2px;border-left-width:1px;background-color:rgb(255,
                                            255, 255);" border="0"
                                            cellpadding="8"
                                            cellspacing="0">
                                            <tbody>
                                              <tr>
                                                <td>
                                                  <div
style="padding-top:2px;padding-right:2px;padding-bottom:2px;padding-left:2px;">
                                                    <div><span></span><br>
                                                    </div>
                                                    <div
                                                      style="float:right;font-weight:bold;font-size:13px;"><a
moz-do-not-send="true"
href="https://www.google.com/calendar/event?action=VIEW&amp;eid=YWJoMmtwNHAzc3EyNDgybTRjb2llaW1jNm8gc3JpcmFtQG1hcmlycy5uZXQuaW4&amp;tok=MTkjYXNlbmd1cHRAcmVkaGF0LmNvbTYyNWZlYjFmYzg2NWRkNGI2YzAyY2FlYmVkMTIwM2VlZmMxZTY0Mzg&amp;ctz=Asia/Calcutta&amp;hl=en"
                                                        style="color:rgb(34,
                                                        0,
                                                        204);white-space:nowrap;">more
                                                        details »</a><br>
                                                    </div>
                                                    <h3
                                                      style="padding-top:0px;padding-right:0px;padding-bottom:6px;padding-left:0px;margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0px;font-family:Arial,sans-serif;font-size:16px;font-weight:bold;color:rgb(34,
                                                      34, 34);"><span>Re:
                                                        [Gluster-devel]
                                                        Question on
                                                        merging zfs
                                                        snapshot support
                                                        into the
                                                        mainline
                                                        glusterfs</span><br>
                                                    </h3>
                                                    <div style="padding-bottom:15px;font-size:13px;color:rgb(34, 34, 34);white-space:pre-wrap !important;overflow-wrap:break-word;"><div><span>Hi Sriram,</span>
</div>
<p><span>Could you please join the hangout, so that we can discuss snapshot plugabbility. Thanks</span>
</p><p><span>Meeting Link: <a moz-do-not-send="true" href="https://www.google.com/url?q=https%3A%2F%2Fbluejeans.com%2Fu%2Fasengupt%2F&amp;sa=D&amp;usd=2&amp;usg=AFQjCNHgp0xCwA9DqgdbAc9s2OxthUEHRA">https://bluejeans.com/u/asengu<wbr>pt/</a></span>
</p><p><span>Regards,
Avra</span></p><p><span>On 12/19/2016 01:38 PM, <a moz-do-not-send="true" href="mailto:sriram@marirs.net.in">sriram@marirs.net.in</a> wrote:
&gt; Hi Avra,
&gt;
&gt; Could you help on the below request?  May I abandon the previous submitted patches, and could we consider the latest one?
&gt;
&gt; Sriram
&gt;
&gt;
&gt; On Thu, Dec 15, 2016, at 12:57 PM, <a moz-do-not-send="true" href="mailto:sriram@marirs.net.in">sriram@marirs.net.in</a> wrote:
&gt;&gt; Hi Avra,
&gt;&gt;
&gt;&gt; Thanks for the reply,
&gt;&gt;
&gt;&gt; But the problem I see here is the previous patch set sent would'nt compile individually. So, I merged the changes into a single patch , which i'd posted today. Is it ok to drop all the previous posted patches and consider from the new one? Please suggest.
&gt;&gt;
&gt;&gt; Sriram
&gt;&gt;
&gt;&gt;
&gt;&gt; On Thu, Dec 15, 2016, at 12:45 PM, Avra Sengupta wrote:
&gt;&gt;&gt; Hi Sriram,
&gt;&gt;&gt;
&gt;&gt;&gt; I have already provided comments on the new patch. It seems this new patch while addressing merge cloflicts, has undone some previous patches. I suggest you send this patch on top of the previous patchset(<a moz-do-not-send="true" href="https://www.google.com/url?q=http%3A%2F%2Freview.gluster.org%2F%23%2Fc%2F15554%2F1&amp;sa=D&amp;usd=2&amp;usg=AFQjCNE4gL3TlKKImxMOU_yOKoCFnP27BA">http://review.gluster<wbr>.org/#/c/15554/1</a>) instead of creating a new one. This will allow you to view the diff between the new version and the previous version, and will give u an idea if the diff is something that you added in the patch or got added as part of merge conflict.
&gt;&gt;&gt;
&gt;&gt;&gt; Regards,
&gt;&gt;&gt; Avra
&gt;&gt;&gt;
&gt;&gt;&gt; On 12/15/2016 12:09 PM, <a moz-do-not-send="true" href="mailto:sriram@marirs.net.in">sriram@marirs.net.in</a> wrote:
&gt;&gt;&gt;&gt; Hi Avra,
&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt; I've update the patch according to the comments below. And created a single patch which does the initial modularization. Fixed the tab-&gt;space issue as well. I've raised a new review request for the same bug ID here:
&gt;&gt;&gt;&gt; <a moz-do-not-send="true" href="https://www.google.com/url?q=http%3A%2F%2Freview.gluster.org%2F%23%2Fc%2F16138%2F&amp;sa=D&amp;usd=2&amp;usg=AFQjCNGST3yFW0o5r4X5DiUXR0GOvgUUUQ">http://review.gluster.org/#/c/<wbr>16138/</a>
&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt; Added, Rajesh and You as the reviewers, let me know if I need to do anything else.
&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt; Could you have a look and let me know?
&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt; (Sorry for the delay in creating this)
&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt; Sriram
&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt; On Thu, Oct 13, 2016, at 12:15 PM, Avra Sengupta wrote:
&gt;&gt;&gt;&gt;&gt; Hi Sriram,
&gt;&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt;&gt; The point I was trying to make is, that we want that each patch should compile by itself, and pass regression. So for that to happen, we need to consolidate these patches(the first three) into one patch, and have the necessary make file changes into that patch too.
&gt;&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt;&gt; <a moz-do-not-send="true" href="https://www.google.com/url?q=http%3A%2F%2Freview.gluster.org%2F%23%2Fc%2F15554%2F&amp;sa=D&amp;usd=2&amp;usg=AFQjCNEgad6GCmPU7P8S1wod8fgs-vOJLw">http://review.gluster.org/#/c/<wbr>15554/</a>
&gt;&gt;&gt;&gt;&gt; <a moz-do-not-send="true" href="https://www.google.com/url?q=http%3A%2F%2Freview.gluster.org%2F%23%2Fc%2F15555%2F&amp;sa=D&amp;usd=2&amp;usg=AFQjCNG6W-AdS5f66QUqkj1ywoxXGes7NQ">http://review.gluster.org/#/c/<wbr>15555/</a>
&gt;&gt;&gt;&gt;&gt; <a moz-do-not-send="true" href="https://www.google.com/url?q=http%3A%2F%2Freview.gluster.org%2F%23%2Fc%2F15556%2F&amp;sa=D&amp;usd=2&amp;usg=AFQjCNG_1vMwB5YePfBQSG0lhYUTxoAM3w">http://review.gluster.org/#/c/<wbr>15556/</a>
&gt;&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt;&gt; That will give us one single patch, that contains the changes of having the current code moved into separate files, and it should get compiled on it's own, and should pass regression. Also, we use spaces, and not tabs in the code. So we will need to get those changed too. Thanks.
&gt;&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt;&gt; Regards,
&gt;&gt;&gt;&gt;&gt; Avra
&gt;&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt;&gt; On 10/12/2016 10:46 PM, <a moz-do-not-send="true" href="mailto:sriram@marirs.net.in">sriram@marirs.net.in</a> wrote:
&gt;&gt;&gt;&gt;&gt;&gt; Hi Avra,
&gt;&gt;&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt;&gt;&gt; Could you let me know on the below request?
&gt;&gt;&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt;&gt;&gt; Sriram
&gt;&gt;&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt;&gt;&gt; On Tue, Oct 4, 2016, at 11:16 AM, <a moz-do-not-send="true" href="mailto:sriram@marirs.net.in">sriram@marirs.net.in</a> wrote:
&gt;&gt;&gt;&gt;&gt;&gt;&gt; Hi Avra,
&gt;&gt;&gt;&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt;&gt;&gt;&gt; I checked the comment, the series of patches, (There are nine patches) for which I've posted for a review below. They've all the necessary makefiles to compile.
&gt;&gt;&gt;&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt;&gt;&gt;&gt; Would you want me to consolidate all'em and post them as a single patch? (I thought that would be a little confusing, since it'd changes with different intentions). 
&gt;&gt;&gt;&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt;&gt;&gt;&gt; Sriram
&gt;&gt;&gt;&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt;&gt;&gt;&gt; On Mon, Oct 3, 2016, at 03:54 PM, Avra Sengupta wrote:
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt; Hi Sriram,
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt; I posted a comment into the first patch. It doesn't compile by itself. We need to update the respective makefiles to be able to compile it. Then we can introduce the tabular structure in the same patch to have the framework set for the zfs snapshots. Thanks.
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt; Regards,
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt; Avra
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt; On 09/30/2016 10:24 AM, <a moz-do-not-send="true" href="mailto:sriram@marirs.net.in">sriram@marirs.net.in</a> wrote:
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt; Hi Avra,
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt; Could you have a look into the below request?
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt; Sriram
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt; On Fri, Sep 23, 2016, at 04:10 PM, <a moz-do-not-send="true" href="mailto:sriram@marirs.net.in">sriram@marirs.net.in</a> wrote:
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt; Hi Avra,
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt; Have submitted the patches for Modularizing snapshot,
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt; <a moz-do-not-send="true" href="https://www.google.com/url?q=https%3A%2F%2Fbugzilla.redhat.com%2Fshow_bug.cgi%3Fid%3D1377437&amp;sa=D&amp;usd=2&amp;usg=AFQjCNFg-7VmX5CLxzVmud3uCFN8S8CDoA">https://bugzilla.redhat.com/sh<wbr>ow_bug.cgi?id=1377437</a>
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt; This is the patch set:
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt; <a moz-do-not-send="true" href="https://www.google.com/url?q=http%3A%2F%2Freview.gluster.org%2F15554&amp;sa=D&amp;usd=2&amp;usg=AFQjCNHk_z5vu62VRSnxCltQhL-8H7w5-w">http://review.gluster.org/1555<wbr>4</a> This patch follows the discussion from the gluster-devel mail chain of, ...
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt; <a moz-do-not-send="true" href="https://www.google.com/url?q=http%3A%2F%2Freview.gluster.org%2F15555&amp;sa=D&amp;usd=2&amp;usg=AFQjCNFtjkyj_R7NYpRk-tnP3ol4tpthYQ">http://review.gluster.org/1555<wbr>5</a> Referring to bugID:1377437, Modularizing snapshot for plugin based modules.
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt; <a moz-do-not-send="true" href="https://www.google.com/url?q=http%3A%2F%2Freview.gluster.org%2F15556&amp;sa=D&amp;usd=2&amp;usg=AFQjCNEi_WhUMxIIYJe2LZ6b43yFJtO9YA">http://review.gluster.org/1555<wbr>6</a> - This is third patch in the series for the bug=1377437
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt; <a moz-do-not-send="true" href="https://www.google.com/url?q=http%3A%2F%2Freview.gluster.org%2F15557&amp;sa=D&amp;usd=2&amp;usg=AFQjCNH7GHU6yX6hZrloWQOovx3sRni2pQ">http://review.gluster.org/1555<wbr>7</a> [BugId:1377437][Patch4]: Refering to the bug ID,
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt; <a moz-do-not-send="true" href="https://www.google.com/url?q=http%3A%2F%2Freview.gluster.org%2F15558&amp;sa=D&amp;usd=2&amp;usg=AFQjCNEdvqKP6ZkiNzBS6PG0V4yXPPe2Mg">http://review.gluster.org/1555<wbr>8</a> [BugId:1377437][Patch5]: Refering to the bug ID,
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt; <a moz-do-not-send="true" href="https://www.google.com/url?q=http%3A%2F%2Freview.gluster.org%2F15559&amp;sa=D&amp;usd=2&amp;usg=AFQjCNEapBOtXvqFtGb5va2ZzWgtD2BFIQ">http://review.gluster.org/1555<wbr>9</a> [BugId:1377437][Patch6]: Refering to the bug ID,
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt; <a moz-do-not-send="true" href="https://www.google.com/url?q=http%3A%2F%2Freview.gluster.org%2F15560&amp;sa=D&amp;usd=2&amp;usg=AFQjCNHs2bZyIlC78giiYEi-4q2-PA6IMw">http://review.gluster.org/1556<wbr>0</a> [BugId:1377437][Patch7]: Refering to the bug ID. * This patch has some minor ...
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt; <a moz-do-not-send="true" href="https://www.google.com/url?q=http%3A%2F%2Freview.gluster.org%2F15561&amp;sa=D&amp;usd=2&amp;usg=AFQjCNGFuuYDikEfaccqIiQ_Bo-amMC1Jw">http://review.gluster.org/1556<wbr>1</a> [BugId:1377437][Patch8]: Refering to the bug ID, this commit has minor fixes ...
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt; <a moz-do-not-send="true" href="https://www.google.com/url?q=http%3A%2F%2Freview.gluster.org%2F15562&amp;sa=D&amp;usd=2&amp;usg=AFQjCNGH9R8bTbHfGsVvL9R-1m41gGHGRg">http://review.gluster.org/1556<wbr>2</a> [BugId:1377437][Patch9]: Refering to the bug ID, - Minor header file ...
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt; Primarily, focused on moving lvm based implementation into plugins. Have spread the commits across nine patches, some of them are minors, except a couple of ones which does the real work. Others are minors. Followed this method since, it would be easy for a review (accept/reject). Let me know if there is something off the methods followed with gluster devel. Thanks
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt; Sriram
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt; On Mon, Sep 19, 2016, at 10:58 PM, Avra Sengupta wrote:
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt; Hi Sriram,
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt; I have created a bug for this (<a moz-do-not-send="true" href="https://www.google.com/url?q=https%3A%2F%2Fbugzilla.redhat.com%2Fshow_bug.cgi%3Fid%3D1377437&amp;sa=D&amp;usd=2&amp;usg=AFQjCNFg-7VmX5CLxzVmud3uCFN8S8CDoA">https://bugzilla.redhat.com/s<wbr>how_bug.cgi?id=1377437</a>). The plan is that for the first patch as mentioned below, let's not meddle with the zfs code at all. What we are looking at is segregating the lvm based code as is today, from the management infrastructure (which is addressed in your patch), and creating a table based pluggable infra(refer to gd_svc_cli_actors[] in xlators/mgmt/glusterd/src/glus<wbr>terd-handler.c and other similar tables in gluster code base to get a understanding of what I am conveying), which can be used to call this code and still achieve the same results as we do today.
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt; Once this code is merged, we can use the same infra to start pushing in the zfs code (rest of your current patch). Please let me know if you have further queries regarding this. Thanks.
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt; Regards,
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt; Avra
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt; On 09/19/2016 07:52 PM, <a moz-do-not-send="true" href="mailto:sriram@marirs.net.in">sriram@marirs.net.in</a> wrote:
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt; Hi Avra,
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt; Do you have a bug id for this changes? Or may I raise a new one?
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt; Sriram
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt; On Fri, Sep 16, 2016, at 11:37 AM, <a moz-do-not-send="true" href="mailto:sriram@marirs.net.in">sriram@marirs.net.in</a> wrote:
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt; Thanks Avra,
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt; I'll send this patch to gluster master in a while.
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt; Sriram
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt; On Wed, Sep 14, 2016, at 03:08 PM, Avra Sengupta wrote:
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt; Hi Sriram,
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt; Sorry for the delay in response. I started going through the commits in the github repo. I finished going through the first commit, where you create a plugin structure and move code. Following is the commit link:
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt; <a moz-do-not-send="true" href="https://www.google.com/url?q=https%3A%2F%2Fgithub.com%2Fsriramster%2Fglusterfs%2Fcommit%2F7bf157525539541ebf0aa36a380bbedb2cae5440&amp;sa=D&amp;usd=2&amp;usg=AFQjCNEo6QDZCzyg9yMQ4mqkY0zM6Z9krg">https://github.com/sriramster/<wbr>glusterfs/commit/7bf1575255395<wbr>41ebf0aa36a380bbedb2cae5440</a>
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt; FIrst of all, the overall approach of using plugins, and maintaining plugins that is used in the patch is in sync with what we had discussed. There are some gaps though, like in the zfs functions the snap brick is mounted without updating labels, and in restore you perform a zfs rollback, which significantly changes the behavior between how a lvm based snapshot and a zfs based snapshot.
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt; But before we get into these details, I would request you to kindly send this particular patch to the g</span></p><p>
</p><p>
</p><p>
</p><div><span></span>
</div>
</div>
<table summary="Event details" border="0" cellpadding="0" cellspacing="0"><tbody><tr><td style="padding-top:0px;padding-right:1em;padding-bottom:10px;padding-left:0px;font-family:Arial,sans-serif;font-size:13px;color:rgb(136, 136, 136);white-space:nowrap;" valign="top"><div><i style="font-style:normal;">When</i>
</div>
</td><td style="padding-bottom:10px;font-family:Arial,sans-serif;font-size:13px;color:rgb(34, 34, 34);" valign="top">Tue Dec 20, 2016 2:30pm – 3:30pm <span class="colour" style="color:rgb(136, 136, 136)">India Standard Time</span>
</td></tr><tr><td style="padding-top:0px;padding-right:1em;padding-bottom:10px;padding-left:0px;font-family:Arial,sans-serif;font-size:13px;color:rgb(136, 136, 136);white-space:nowrap;" valign="top"><div><i style="font-style:normal;">Calendar</i>
</div>
</td><td style="padding-bottom:10px;font-family:Arial,sans-serif;font-size:13px;color:rgb(34, 34, 34);" valign="top"><a moz-do-not-send="true" href="mailto:sriram@marirs.net.in">sriram@marirs.net.in</a>
</td></tr><tr><td style="padding-top:0px;padding-right:1em;padding-bottom:10px;padding-left:0px;font-family:Arial,sans-serif;font-size:13px;color:rgb(136, 136, 136);white-space:nowrap;" valign="top"><div><i style="font-style:normal;">Who</i>
</div>
</td><td style="padding-bottom:10px;font-family:Arial,sans-serif;font-size:13px;color:rgb(34, 34, 34);" valign="top"><table cellpadding="0" cellspacing="0"><tbody><tr><td style="padding-right:10px;font-family:Arial,sans-serif;font-size:13px;color:rgb(34, 34, 34);"><span class="font" style="font-family:Courier New,monospace">•</span>
</td><td style="padding-right:10px;font-family:Arial,sans-serif;font-size:13px;color:rgb(34, 34, 34);"><div><div style="margin-top:0px;margin-right:0px;margin-bottom:0.3em;margin-left:0px;"><span><span><a moz-do-not-send="true" href="mailto:asengupt@redhat.com">asengupt@redhat.com</a></span></span><span class="colour" style="color:rgb(136, 136, 136)"><span class="size" style="font-size:11px"> - organizer</span></span>
</div>
</div>
</td></tr><tr><td style="padding-right:10px;font-family:Arial,sans-serif;font-size:13px;color:rgb(34, 34, 34);"><span class="font" style="font-family:Courier New,monospace">•</span>
</td><td style="padding-right:10px;font-family:Arial,sans-serif;font-size:13px;color:rgb(34, 34, 34);"><div><div style="margin-top:0px;margin-right:0px;margin-bottom:0.3em;margin-left:0px;"><span><span><a moz-do-not-send="true" href="mailto:rjoseph@redhat.com">rjoseph@redhat.com</a></span></span>
</div>
</div>
</td></tr><tr><td style="padding-right:10px;font-family:Arial,sans-serif;font-size:13px;color:rgb(34, 34, 34);"><span class="font" style="font-family:Courier New,monospace">•</span>
</td><td style="padding-right:10px;font-family:Arial,sans-serif;font-size:13px;color:rgb(34, 34, 34);"><div><div style="margin-top:0px;margin-right:0px;margin-bottom:0.3em;margin-left:0px;"><span><span><a moz-do-not-send="true" href="mailto:ram@fractalio.com">ram@fractalio.com</a></span></span>
</div>
</div>
</td></tr><tr><td style="padding-right:10px;font-family:Arial,sans-serif;font-size:13px;color:rgb(34, 34, 34);"><span class="font" style="font-family:Courier New,monospace">•</span>
</td><td style="padding-right:10px;font-family:Arial,sans-serif;font-size:13px;color:rgb(34, 34, 34);"><div><div style="margin-top:0px;margin-right:0px;margin-bottom:0.3em;margin-left:0px;"><span><span><a moz-do-not-send="true" href="mailto:gluster-devel@gluster.org">gluster-devel@gluster.org</a></span></span>
</div>
</div>
</td></tr><tr><td style="padding-right:10px;font-family:Arial,sans-serif;font-size:13px;color:rgb(34, 34, 34);"><span class="font" style="font-family:Courier New,monospace">•</span>
</td><td style="padding-right:10px;font-family:Arial,sans-serif;font-size:13px;color:rgb(34, 34, 34);"><div><div style="margin-top:0px;margin-right:0px;margin-bottom:0.3em;margin-left:0px;"><span><span><a moz-do-not-send="true" href="mailto:sriram@marirs.net.in">sriram@marirs.net.in</a></span></span>
</div>
</div>
</td></tr></tbody></table></td></tr></tbody></table></div>
<p style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0px;"><span class="colour" style="color:rgb(34, 34, 34)"><span class="size" style="font-size:13px"><span class="colour" style="color:rgb(136, 136, 136)">Going?   </span><b><span><span><a moz-do-not-send="true" href="https://www.google.com/calendar/event?action=RESPOND&amp;eid=YWJoMmtwNHAzc3EyNDgybTRjb2llaW1jNm8gc3JpcmFtQG1hcmlycy5uZXQuaW4&amp;rst=1&amp;tok=MTkjYXNlbmd1cHRAcmVkaGF0LmNvbTYyNWZlYjFmYzg2NWRkNGI2YzAyY2FlYmVkMTIwM2VlZmMxZTY0Mzg&amp;ctz=Asia/Calcutta&amp;hl=en" style="color:rgb(34, 0, 204);white-space:nowrap;">Yes</a></span></span><span style="margin-top:0px;margin-right:0.4em;margin-bottom:0px;margin-left:0.4em;font-weight:normal;"> - </span><span><span><a moz-do-not-send="true" href="https://www.google.com/calendar/event?action=RESPOND&amp;eid=YWJoMmtwNHAzc3EyNDgybTRjb2llaW1jNm8gc3JpcmFtQG1hcmlycy5uZXQuaW4&amp;rst=3&amp;tok=MTkjYXNlbmd1cHRAcmVkaGF0LmNvbTYyNWZlYjFmYzg2NWRkNGI2YzAyY2FlYmVkMT!
 IwM2VlZmMx
ZTY0Mzg&amp;ctz=Asia/Calcutta&amp;hl=en" style="color:rgb(34, 0, 204);white-space:nowrap;">Maybe</a></span></span><span style="margin-top:0px;margin-right:0.4em;margin-bottom:0px;margin-left:0.4em;font-weight:normal;"> - </span><span><span><a moz-do-not-send="true" href="https://www.google.com/calendar/event?action=RESPOND&amp;eid=YWJoMmtwNHAzc3EyNDgybTRjb2llaW1jNm8gc3JpcmFtQG1hcmlycy5uZXQuaW4&amp;rst=2&amp;tok=MTkjYXNlbmd1cHRAcmVkaGF0LmNvbTYyNWZlYjFmYzg2NWRkNGI2YzAyY2FlYmVkMTIwM2VlZmMxZTY0Mzg&amp;ctz=Asia/Calcutta&amp;hl=en" style="color:rgb(34, 0, 204);white-space:nowrap;">No</a></span></span></b>    <a moz-do-not-send="true" href="https://www.google.com/calendar/event?action=VIEW&amp;eid=YWJoMmtwNHAzc3EyNDgybTRjb2llaW1jNm8gc3JpcmFtQG1hcmlycy5uZXQuaW4&amp;tok=MTkjYXNlbmd1cHRAcmVkaGF0LmNvbTYyNWZlYjFmYzg2NWRkNGI2YzAyY2FlYmVkMTIwM2VlZmMxZTY0Mzg&amp;ctz=Asia/Calcutta&amp;hl=en" style="color:rgb(34, 0, 204);white-space:nowrap;">more options »</a></span></span>
</p></td></tr><tr><td style="background-color:rgb(246, 246, 246);color:rgb(136, 136, 136);border-top-width:1px;border-top-style:solid;border-top-color:rgb(204, 204, 204);font-family:Arial,sans-serif;font-size:11px;"><p>Invitation from <a moz-do-not-send="true" href="https://www.google.com/calendar/">Google Calendar</a>
</p><p>You are receiving this courtesy email at the account <a moz-do-not-send="true" href="mailto:sriram@marirs.net.in">sriram@marirs.net.in</a> because you are an attendee of this event.
</p><p>To stop receiving future updates for this event, decline this event. Alternatively you can sign up for a Google account at <a moz-do-not-send="true" href="https://www.google.com/calendar/">https://www.google.com/calenda<wbr>r/</a> and control your notification settings for your entire calendar.
</p><p>Forwarding this invitation could allow any recipient to modify your RSVP response. <a moz-do-not-send="true" href="https://support.google.com/calendar/answer/37135#forwarding">Learn More</a>.
</p></td></tr></tbody></table></span></span></div>
<div><span><span></span></span>
</div>
<p>Email had 2 attachments:
</p><ul><li><div><code>Attachment1.3</code>
</div>
<div>  10k (text/calendar)
</div>
</li><li><div><code>invite.ics</code>
</div>
<div>  14k (application/ics)
</div>
</li></ul></blockquote><div>
</div>
<div><u>______________________________<wbr>_________________</u>
</div>
<div>Gluster-devel mailing list
</div>
<div><a moz-do-not-send="true" href="mailto:Gluster-devel@gluster.org">Gluster-devel@gluster.org</a>
</div>
<div><a moz-do-not-send="true" href="http://www.gluster.org/mailman/listinfo/gluster-devel">http://www.gluster.org/mailman<wbr>/listinfo/gluster-devel</a>
</div>
</blockquote><div>
</div>
</div>
</blockquote></div>
</div>
</div>
</blockquote><div>
</div>
</div>
</div>
</div>
</blockquote></div>
</div>
</blockquote><div>
</div>





</blockquote>
</body></html>