<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Nov 10, 2016 at 9:33 PM, Manikandan Selvaganesh <span dir="ltr"><<a target="_blank" href="mailto:manikandancs333@gmail.com">manikandancs333@gmail.com</a>></span> wrote:<br><blockquote style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex" class="gmail_quote"><br><p dir="ltr">No problem. As you said , glusterd_quota_limit_usage invokes the function which regenerates the conf file. Though I do not remember exactly, to my understanding when I tried, it did not work properly in my setup. It is apparently because in the later function where we regenerate the quota.conf for versions greater than or equal to 3.7, when it is setting a limit or ideally when you are resetting a limit, it searches for the gfid on which it needs to set/reset the limit and modify only that to 17 bytes leaving the remaining ones untouched which again would result in unexpected behavior. In the case of enable or disable, the entire file gets newly generated. With this patch, we have done that during an upgrade as well. </p></blockquote><div> </div><div> The code seems to handles this. The first thing done (before parsing for gfid) is to bring the conf to 1.2 version in glusterd_store_quota_config.<br><br></div><blockquote style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex" class="gmail_quote">
<p dir="ltr">Even I am not completely sure. Anyways its better to test and confirm the fact. I can test the same over the weekend if it's fine.</p></blockquote></div><br>Ran into an unrelated set up issue at my end while testing this, I Will test this before noon.<br><br></div><div class="gmail_extra">Thanks and Regards,<br></div><div class="gmail_extra">Sanoj<br></div><div class="gmail_extra"><br></div></div>