<div dir="ltr">Hi Hari,<div><br></div><div>I have done a very initial review for some of the files. I have just</div><div>reviewed the code flow without having much idea on the actual functionality. Please</div><div>feel free to address it when you have time(since most of them are coverity, indentation</div><div>and memory issues related).</div><div><br></div><div>I will also review the remaining files when I get time.</div></div><div class="gmail_extra"><br clear="all"><div><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>--</div><div>Thanks & Regards,</div><div>Manikandan Selvaganesh.</div></div></div></div></div></div>
<br><div class="gmail_quote">On Thu, Sep 15, 2016 at 2:22 PM, Niels de Vos <span dir="ltr"><<a href="mailto:ndevos@redhat.com" target="_blank">ndevos@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Thu, Sep 15, 2016 at 02:50:09AM -0400, Hari Gowtham wrote:<br>
> Hi,<br>
><br>
> I would be happy to get reviews for this patch<br>
> <a href="http://review.gluster.org/#/c/13365/" rel="noreferrer" target="_blank">http://review.gluster.org/#/c/<wbr>13365/</a><br>
><br>
> more details can be found here about the changes:<br>
> <a href="https://docs.google.com/document/d/1_iyjiwTLnBJlCiUgjAWnpnPD801h5LNxLhHmN7zmk1o/edit?usp=sharing" rel="noreferrer" target="_blank">https://docs.google.com/<wbr>document/d/1_<wbr>iyjiwTLnBJlCiUgjAWnpnPD801h5LN<wbr>xLhHmN7zmk1o/edit?usp=sharing</a><br>
<br>
</span>Please send this as a document for the glusterfs-specs repository (uses<br>
Gerrit just like the glusterfs sources). See the README.md on<br>
<a href="https://github.com/gluster/glusterfs-specs/blob/master/README.md" rel="noreferrer" target="_blank">https://github.com/gluster/<wbr>glusterfs-specs/blob/master/<wbr>README.md</a> for<br>
some more details.<br>
<br>
Thanks,<br>
Niels<br>
<br>______________________________<wbr>_________________<br>
Gluster-devel mailing list<br>
<a href="mailto:Gluster-devel@gluster.org">Gluster-devel@gluster.org</a><br>
<a href="http://www.gluster.org/mailman/listinfo/gluster-devel" rel="noreferrer" target="_blank">http://www.gluster.org/<wbr>mailman/listinfo/gluster-devel</a><br></blockquote></div><br></div>