The patch <a href="http://review.gluster.org/#/c/15331/">http://review.gluster.org/#/c/15331/</a> is now ready for merge.<div><br></div><div>Niels - could you merge it?<span></span><br><br>On Saturday 27 August 2016, Prasanna Kalever <<a href="mailto:pkalever@redhat.com">pkalever@redhat.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Oops!<br>
Didn't noticed these changes were part of parent/child patches, Just<br>
noticed "BUILD BROKEN" and went into action :)<br>
<br>
I'm not sure about it!<br>
<br>
If it takes time to decide on whether the other set of patches need to<br>
be taken or not, at-least my patch will fix the broken build (That<br>
much I can assure)<br>
<br>
Lets see if the regressions break after these patch goes in (mostly<br>
not, that I see from the code)<br>
<br>
Thanks,<br>
--<br>
Prasanna<br>
<br>
<br>
On Sat, Aug 27, 2016 at 8:34 PM, Atin Mukherjee<br>
<<a href="javascript:;" onclick="_e(event, 'cvml', 'atin.mukherjee83@gmail.com')">atin.mukherjee83@gmail.com</a>> wrote:<br>
><br>
><br>
> On Saturday 27 August 2016, Prasanna Kalever <<a href="javascript:;" onclick="_e(event, 'cvml', 'pkalever@redhat.com')">pkalever@redhat.com</a>> wrote:<br>
>><br>
>> Here is the patch that should fix it<br>
>> <a href="http://review.gluster.org/#/c/15331/" target="_blank">http://review.gluster.org/#/c/<wbr>15331/</a><br>
><br>
><br>
> Thanks! Well thats an easy way, but the question here is dont we need the<br>
> parent patch to be merged to ensure there is no other functionality broken.<br>
> Currently I see that the parent patch has a -1, in that case is it required<br>
> to revert 15225?<br>
>><br>
>><br>
>> Happy weekend!<br>
>><br>
>> --<br>
>> Prasanna<br>
>><br>
>><br>
>> On Sat, Aug 27, 2016 at 7:49 PM, Atin Mukherjee <<a href="javascript:;" onclick="_e(event, 'cvml', 'amukherj@redhat.com')">amukherj@redhat.com</a>><br>
>> wrote:<br>
>> > [1] has broken mainline compilation and I feel this could be because its<br>
>> > parent patch is not been merged otherwise smoke should have caught it.<br>
>> > Please resolve it at earliest.<br>
>> ><br>
>> > [1] <a href="http://review.gluster.org/#/c/15225/" target="_blank">http://review.gluster.org/#/c/<wbr>15225/</a><br>
>> ><br>
>> ><br>
>> > --Atin<br>
>> ><br>
>> > ______________________________<wbr>_________________<br>
>> > Gluster-devel mailing list<br>
>> > <a href="javascript:;" onclick="_e(event, 'cvml', 'Gluster-devel@gluster.org')">Gluster-devel@gluster.org</a><br>
>> > <a href="http://www.gluster.org/mailman/listinfo/gluster-devel" target="_blank">http://www.gluster.org/<wbr>mailman/listinfo/gluster-devel</a><br>
>> ______________________________<wbr>_________________<br>
>> Gluster-devel mailing list<br>
>> <a href="javascript:;" onclick="_e(event, 'cvml', 'Gluster-devel@gluster.org')">Gluster-devel@gluster.org</a><br>
>> <a href="http://www.gluster.org/mailman/listinfo/gluster-devel" target="_blank">http://www.gluster.org/<wbr>mailman/listinfo/gluster-devel</a><br>
><br>
><br>
><br>
> --<br>
> --Atin<br>
</blockquote></div><br><br>-- <br>--Atin<br>