<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
<br>
1. We do not clear the Verified tag. This means if you want to re-run<br>
regressions you have to manually trigger it. If your patch is rebased on top<br>
of another patch, you may have to retrigger failing regressions manually.<br></blockquote><div>Yes, matching the settings for Verified flag to that of regressions is right thing to do.</div><div>Users can use the rechech netbsd/centos/smoke option to retrigger specific tests.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
2. We do give automatic +1 for regressions if the change is *only* in<br>
`extras/`, to MAINTAINERS file and other no-op changes. Please correct me<br>
here. I think the changes here do not affect regressions. If I'm wrong and<br>
they do, I'd love to know which files do affect regressions. I've taken the<br>
MAINTAINERS file as an example, I'm also curious to know what other no-op<br>
changes can be made.<br></blockquote><div><br></div><div>Unfortunately, the directory structure isn't that organised. What you say holds true for MAINTAINERS file, tests/distaf/* and doc/*. We skip regressions for changes in distaf/* and doc/* today. Extras folder has code though.</div><div><br></div><div>Given below is a simple grep which shows files that reside in extras but get installed as part of make/packages. Some of the scripts found in this list are tested in the regression tests.<br></div><div><br></div><div><div>45: extras/peer_add_secret_pub</div><div>214: extras/Makefile</div><div>215: extras/glusterd.vol</div><div>216: extras/cliutils/Makefile</div><div>217: extras/init.d/Makefile</div><div>218: extras/init.d/glusterd.plist</div><div>219: extras/init.d/glusterd-Debian</div><div>220: extras/init.d/glusterd-Redhat</div><div>221: extras/init.d/glusterd-FreeBSD</div><div>222: extras/init.d/glusterd-SuSE</div><div>223: extras/ganesha/Makefile</div><div>224: extras/ganesha/config/Makefile</div><div>225: extras/ganesha/scripts/Makefile</div><div>226: extras/ganesha/ocf/Makefile</div><div>227: extras/systemd/Makefile</div><div>228: extras/systemd/glusterd.service</div><div>229: extras/systemd/glustereventsd.service</div><div>230: extras/run-gluster.tmpfiles</div><div>231: extras/benchmarking/Makefile</div><div>232: extras/hook-scripts/Makefile</div><div>233: extras/ocf/Makefile</div><div>234: extras/ocf/glusterd</div><div>235: extras/ocf/volume</div><div>236: extras/LinuxRPM/Makefile</div><div>237: extras/geo-rep/Makefile</div><div>238: extras/geo-rep/schedule_georep.py</div><div>239: extras/firewalld/Makefile</div><div>240: extras/hook-scripts/add-brick/Makefile</div><div>241: extras/hook-scripts/add-brick/pre/Makefile</div><div>242: extras/hook-scripts/add-brick/post/Makefile</div><div>243: extras/hook-scripts/start/Makefile</div><div>244: extras/hook-scripts/start/post/Makefile</div><div>245: extras/hook-scripts/set/Makefile</div><div>246: extras/hook-scripts/set/post/Makefile</div><div>247: extras/hook-scripts/stop/Makefile</div><div>248: extras/hook-scripts/stop/pre/Makefile</div><div>249: extras/hook-scripts/reset/Makefile</div><div>250: extras/hook-scripts/reset/post/Makefile</div><div>251: extras/hook-scripts/reset/pre/Makefile</div><div>252: extras/snap_scheduler/Makefile</div><div>720:# only install scripts from extras/geo-rep when enabled</div><div>722: GEOREP_EXTRAS_SUBDIR=geo-rep</div><div>724:AC_SUBST(GEOREP_EXTRAS_SUBDIR)</div><div>2076:install -D -p -m 0644 extras/glusterd-sysconfig \</div><div>2137:install -D -p -m 0644 extras/glusterfs-logrotate \</div><div>2144:install -D -p -m 0644 extras/glusterfs-georep-logrotate \</div><div>2170:install -p -m 0744 -D extras/command-completion/gluster.bash \</div><div>2521:%doc extras/clear_xattrs.sh</div><div>2933:- Include extras/clear_xattrs.sh in the glusterfs-server sub-package</div></div><div><br></div><div><br></div><div><br></div><div> </div><div><br></div><div><br></div></div></div></div>