<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Jul 23, 2016 at 10:17 AM, Nithya Balachandran <span dir="ltr"><<a href="mailto:nbalacha@redhat.com" target="_blank">nbalacha@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span class="">On Sat, Jul 23, 2016 at 9:45 AM, Nithya Balachandran <span dir="ltr"><<a href="mailto:nbalacha@redhat.com" target="_blank">nbalacha@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span>On Fri, Jul 22, 2016 at 9:07 PM, Pranith Kumar Karampuri <span dir="ltr"><<a href="mailto:pkarampu@redhat.com" target="_blank">pkarampu@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span>On Fri, Jul 22, 2016 at 8:12 PM, Pranith Kumar Karampuri <span dir="ltr"><<a href="mailto:pkarampu@redhat.com" target="_blank">pkarampu@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">I am playing with the following diff, let me see.<br><br>diff --git a/tests/volume.rc b/tests/volume.rc<br>index 331a802..b288508 100644<br>--- a/tests/volume.rc<br>+++ b/tests/volume.rc<br>@@ -579,7 +579,9 @@ function num_graphs<br> function get_aux()<br> {<br> ##Check if a auxiliary mount is there<br>-df -h 2>&1 | sed 's#/build/install##' | grep -e "[[:space:]]/run/gluster/${V0}$" -e "[[:space:]]/var/run/gluster/${V0}$" -<br>+local rundir=$(gluster --print-statedumpdir)<br>+local pid=$(cat ${rundir}/${V0}.pid)<br>+pidof glusterfs 2>&1 | grep -w $pid<br> <br> if [ $? -eq 0 ]<br> then<br></div></blockquote><div><br></div></span><div>Based on what I saw in code, this seems to get the job done. Comments welcome:<br><a href="http://review.gluster.org/14988" target="_blank">http://review.gluster.org/14988</a><br><br></div></div></div></div></blockquote><div><br></div></span><div>Nice work Pranith :)</div><div>All, once this is backported to release-3.7, any patches on release-3.7 patches will need to be rebased so they will pass the NetBSD regression.</div></div></div></div></blockquote><div><br></div></span><div>I am suddenly confused about this - will the patches need to be rebased or with the next run automatically include the changes once Pranith's fix is merged? </div></div></div></div></blockquote><div><br></div><div>May be someone more knowledgeable about this should confirm this, but at least from the build-log, I don't see any rebase command being executed with origin/master:<br><pre class=""><span class=""><b>04:07:36</b> </span>Triggered by Gerrit: <a href="http://review.gluster.org/13762">http://review.gluster.org/13762</a>
<span class=""><b>04:07:36</b> </span>Building remotely on <a href="https://build.gluster.org/computer/slave26.cloud.gluster.org" class="">slave26.cloud.gluster.org</a> (smoke_tests rackspace_regression_2gb glusterfs-devrpms) in workspace /home/jenkins/root/workspace/rackspace-regression-2GB-triggered
<span class=""><b>04:07:36</b> </span> > git rev-parse --is-inside-work-tree # timeout=10
<span class=""><b>04:07:36</b> </span>Fetching changes from the remote Git repository
<span class=""><b>04:07:36</b> </span> > git config remote.origin.url git://<a href="http://review.gluster.org/glusterfs.git">review.gluster.org/glusterfs.git</a> # timeout=10
<span class=""><b>04:07:36</b> </span>Fetching upstream changes from git://<a href="http://review.gluster.org/glusterfs.git">review.gluster.org/glusterfs.git</a>
<span class=""><b>04:07:36</b> </span> > git --version # timeout=10
<span class=""><b>04:07:36</b> </span> > git -c core.askpass=true fetch --tags --progress git://<a href="http://review.gluster.org/glusterfs.git">review.gluster.org/glusterfs.git</a> refs/changes/62/13762/4
<span class=""><b>04:07:44</b> </span> > git rev-parse 838b5c34127edd0450b0449e38f075f56056f2c7^{commit} # timeout=10
<span class=""><b>04:07:44</b> </span>Checking out Revision 838b5c34127edd0450b0449e38f075f56056f2c7 (master)
<span class=""><b>04:07:44</b> </span> > git config core.sparsecheckout # timeout=10
<span class=""><b>04:07:44</b> </span> > git checkout -f 838b5c34127edd0450b0449e38f075f56056f2c7
<span class=""><b>04:07:45</b> </span> > git rev-parse FETCH_HEAD^{commit} # timeout=10
<span class=""><b>04:07:45</b> </span> > git rev-list 8cbee639520bf4631ce658e2da9b4bc3010d2eaa # timeout=10
<span class=""><b>04:07:45</b> </span> > git tag -a -f -m Jenkins Build #22315 jenkins-rackspace-regression-2GB-triggered-22315 # timeout=10</pre><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><div class="h5"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><br></div><div class="gmail_extra"><div><div><br><div class="gmail_quote">On Fri, Jul 22, 2016 at 7:44 PM, Nithya Balachandran <span dir="ltr"><<a href="mailto:nbalacha@redhat.com" target="_blank">nbalacha@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><div><div>On Fri, Jul 22, 2016 at 7:42 PM, Pranith Kumar Karampuri <span dir="ltr"><<a href="mailto:pkarampu@redhat.com" target="_blank">pkarampu@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span>On Fri, Jul 22, 2016 at 7:39 PM, Nithya Balachandran <span dir="ltr"><<a href="mailto:nbalacha@redhat.com" target="_blank">nbalacha@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span>On Fri, Jul 22, 2016 at 7:31 PM, Jeff Darcy <span dir="ltr"><<a href="mailto:jdarcy@redhat.com" target="_blank">jdarcy@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span>> I attempted to get us more space on NetBSD by creating a new partition called<br>
> /data and putting /build as a symlink to /data/build. This has caused<br>
> problems<br>
> with tests/basic/quota.t. It's marked as bad for master, but not for<br>
> release-3.7. This is possibly because we have a hard-coded grep for<br>
> /build/install against df -h.<br>
<br>
</span>For the benefit of anyone else looking at this, the grep actually seems to be<br>
in volume.rc and not in the test itself.<br></blockquote><div><br></div></span><div>That's right - it appears to have been done to exclude the install path components from the df output which is what is being done to find the aux mount. Is there a better way to figure out if the aux mount is running?</div><span><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<span><br>
> Nithya has spent the last 2 days debugging<br>
> without much success. What's a good way forward here? Mark the test as<br>
> failing for 3.7?<br></span></blockquote><div><br></div></span><div>Right. Something went wrong with the system and it refused to run the tests after a while. </div><span><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span>
<br>
</span>I don't think so. There are 13 tests that use the affected function<br>
(get_aux). Do we want to disable 13 tests? I think we actually need<br>
to fix the function instead. It seems to me that the check we're<br>
making is very hacky in two ways:<br>
<br>
Checking for both /run and /var/run instead of using GLUSTERD_WORKDIR<br>
<br>
Excluding /build/install for no obvious reason at all<br></blockquote><div><br></div></span><div>This looks like it was done to remove the /build/install components from the df -h outputs. Changing the path to /data/build/install broke this as it did not strip the "/data" from the paths.</div><div>It did work when I changed the sed to act on /data/build/install but hardcoded paths are not a good approach.</div></div></div></div></blockquote><div><br></div></span><div>Give me some time, I can send out a patch to print out the default run directory if that helps?<br></div><div>something similar to 'gluster --print-logdir'. What shall we call this? 'gluster --print-rundir'? it will <br></div><span><div> </div></span></div></div></div></blockquote><div><br></div></div></div><div>This path might be available as an env variable - but is there a better way to figure out the aux mount without bothering with df -h? </div><span><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
These auxiliary mounts should be in a much more specific place, and we<br>
should check for that instead of looking for any that might exist. Who<br>
knows where that place is? I've copied Raghavendra G as the quota<br>
maintainer, since that seems like our best bet.<br>
<div><div>_______________________________________________<br>
Gluster-devel mailing list<br>
<a href="mailto:Gluster-devel@gluster.org" target="_blank">Gluster-devel@gluster.org</a><br>
<a href="http://www.gluster.org/mailman/listinfo/gluster-devel" rel="noreferrer" target="_blank">http://www.gluster.org/mailman/listinfo/gluster-devel</a><br>
</div></div></blockquote></span></div><br></div></div>
<br>_______________________________________________<br>
Gluster-devel mailing list<br>
<a href="mailto:Gluster-devel@gluster.org" target="_blank">Gluster-devel@gluster.org</a><br>
<a href="http://www.gluster.org/mailman/listinfo/gluster-devel" rel="noreferrer" target="_blank">http://www.gluster.org/mailman/listinfo/gluster-devel</a><br></blockquote></span></div><span><font color="#888888"><br><br clear="all"><br>-- <br><div data-smartmail="gmail_signature"><div dir="ltr">Pranith<br></div></div>
</font></span></div></div>
</blockquote></span></div><br></div></div>
</blockquote></div><br><br clear="all"><br></div></div><span><font color="#888888">-- <br><div data-smartmail="gmail_signature"><div dir="ltr">Pranith<br></div></div>
</font></span></div>
</blockquote></div></div></div><span><font color="#888888"><br><br clear="all"><br>-- <br><div data-smartmail="gmail_signature"><div dir="ltr">Pranith<br></div></div>
</font></span></div></div>
</blockquote></div></div></div></div></div></blockquote><div><br></div><div> </div></div></div></div><br></div></div>
</blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">Pranith<br></div></div>
</div></div>