<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Jul 22, 2016 at 7:31 PM, Jeff Darcy <span dir="ltr"><<a href="mailto:jdarcy@redhat.com" target="_blank">jdarcy@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">> I attempted to get us more space on NetBSD by creating a new partition called<br>
> /data and putting /build as a symlink to /data/build. This has caused<br>
> problems<br>
> with tests/basic/quota.t. It's marked as bad for master, but not for<br>
> release-3.7. This is possibly because we have a hard-coded grep for<br>
> /build/install against df -h.<br>
<br>
</span>For the benefit of anyone else looking at this, the grep actually seems to be<br>
in volume.rc and not in the test itself.<br></blockquote><div><br></div><div>That's right - it appears to have been done to exclude the install path components from the df output which is what is being done to find the aux mount. Is there a better way to figure out if the aux mount is running?</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<span class=""><br>
> Nithya has spent the last 2 days debugging<br>
> without much success. What's a good way forward here? Mark the test as<br>
> failing for 3.7?<br></span></blockquote><div><br></div><div>Right. Something went wrong with the system and it refused to run the tests after a while. </div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">
<br>
</span>I don't think so. There are 13 tests that use the affected function<br>
(get_aux). Do we want to disable 13 tests? I think we actually need<br>
to fix the function instead. It seems to me that the check we're<br>
making is very hacky in two ways:<br>
<br>
Checking for both /run and /var/run instead of using GLUSTERD_WORKDIR<br>
<br>
Excluding /build/install for no obvious reason at all<br></blockquote><div><br></div><div>This looks like it was done to remove the /build/install components from the df -h outputs. Changing the path to /data/build/install broke this as it did not strip the "/data" from the paths.</div><div>It did work when I changed the sed to act on /data/build/install but hardcoded paths are not a good approach.</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
These auxiliary mounts should be in a much more specific place, and we<br>
should check for that instead of looking for any that might exist. Who<br>
knows where that place is? I've copied Raghavendra G as the quota<br>
maintainer, since that seems like our best bet.<br>
<div class="HOEnZb"><div class="h5">_______________________________________________<br>
Gluster-devel mailing list<br>
<a href="mailto:Gluster-devel@gluster.org">Gluster-devel@gluster.org</a><br>
<a href="http://www.gluster.org/mailman/listinfo/gluster-devel" rel="noreferrer" target="_blank">http://www.gluster.org/mailman/listinfo/gluster-devel</a><br>
</div></div></blockquote></div><br></div></div>