<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Jul 22, 2016 at 7:07 PM, Jeff Darcy <span dir="ltr"><<a href="mailto:jdarcy@redhat.com" target="_blank">jdarcy@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">> Gah! sorry sorry, I meant to send the mail as SIGTERM. Not SIGKILL. So xavi<br>
> and I were wondering why cleanup_and_exit() is not sending GF_PARENT_DOWN<br>
> event.<br>
<br>
</span>OK, then that grinding sound you hear is my brain shifting gears. ;) It<br>
seems that cleanup_and_exit will call xlator.fini in some few cases, but<br>
it doesn't do anything that would send notify events. I'll bet the answer<br>
to "why" is just that nobody thought of it or got around to it. The next<br>
question I'd ask is: can you do what you need to do from ec.fini instead?<br>
That would require enabling it in should_call_fini as well, but otherwise<br>
seems pretty straightforward.<br>
<br>
If the answer to that question is no, then things get more complicated.<br>
Can we do one loop that sends GF_EVENT_PARENT_DOWN events, then another<br>
that calls fini? Can we just do a basic list traversal (as we do now for<br>
fini) or do we need to do something more complicated to deal with cluster<br>
translators? I think a separate loop doing basic list traversal would<br>
work, even with brick multiplexing, so it's probably worth just coding it<br>
up as an experiment.<br>
</blockquote></div><br>I don't think we need any list traversal because notify sends it down the graph. I guess I will start the experiment then.<br></div><div class="gmail_extra"><br clear="all"><br>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">Pranith<br></div></div>
</div></div>