<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Jul 21, 2016 at 3:07 AM, Vijay Bellur <span dir="ltr"><<a href="mailto:vbellur@redhat.com" target="_blank">vbellur@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="">On 07/19/2016 11:01 AM, Atin Mukherjee wrote:<br>
</span><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="">
<br>
<br>
On Tue, Jul 19, 2016 at 7:29 PM, Rajesh Joseph <<a href="mailto:rjoseph@redhat.com" target="_blank">rjoseph@redhat.com</a><br></span><span class="">
<mailto:<a href="mailto:rjoseph@redhat.com" target="_blank">rjoseph@redhat.com</a>>> wrote:<br>
<br>
<br>
<br>
On Tue, Jul 19, 2016 at 11:23 AM, <<a href="mailto:sriram@marirs.net.in" target="_blank">sriram@marirs.net.in</a><br></span>
<mailto:<a href="mailto:sriram@marirs.net.in" target="_blank">sriram@marirs.net.in</a>>> wrote:<br>
<br>
__<span class=""><br>
Hi Rajesh,<br>
<br>
I'd thought about moving the zfs specific implementation to<br>
something like<br>
<br>
xlators/mgmt/glusterd/src/plugins/zfs-specifs-stuffs for the<br>
inital go. Could you let me know if this works or in sync with<br>
what you'd thought about?<br>
<br>
Sriram<br>
<br>
<br>
Hi Sriram,<br>
<br>
Sorry, I was not able to send much time on this. I would prefer you<br>
move the code to<br>
<br>
xlators/mgmt/glusterd/plugins/src/zfs-specifs-stuffs<br>
<br>
<br>
<br>
How about having it under<br>
xlators/mgmt/glusterd/plugins/snapshot/src/zfs-specifs-stuffs such that<br>
in future if we have to write plugins for other features they can be<br>
segregated?<br>
<br>
</span></blockquote>
<br>
It would be nicer to avoid "specific-stuff" or similar from the naming. We can probably leave it at xlators/mgmt/glusterd/plugins/snapshot/src/zfs. The naming would be sufficient to indicate that code is specific to zfs snapshots.<span class=""><font color="#888888"><br></font></span></blockquote><div><br></div><div>I don't think the directory would be named "zfs-specific_stuffs, instead zfs specific source file will come directly under "xlato<span class="">rs/mgmt/glusterd/plugins/snapshot/src/". I think I should have been more clear, my bad.<br><br></span></div><div><span class="">-Rajesh<br></span></div><br></div></div></div>