<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Jul 15, 2016 at 1:25 AM, Jeff Darcy <span dir="ltr"><<a href="mailto:jdarcy@redhat.com" target="_blank">jdarcy@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">> I absolutely hate what '-1' means though, it says 'I would prefer you<br>
> didn't submit this'. Somebody who doesn't know what he/she is doing still<br>
> goes ahead and sends his/her first patch and we say 'I would prefer you<br>
> didn't submit this'. It is like the tool is working against more<br>
> contributions. It could also say 'Thanks for your contribution, I feel we<br>
> can improve the patch further together' on -1 too you know.<br>
<br>
</span>When it comes to what -1 means, I've noticed quite a bit of variation<br>
across the group. Sometimes it means the person doesn't want it merged<br>
*yet* because of minor issues (including style). Sometimes it means they<br>
think the whole idea or approach is fundamentally misguided and they'll<br>
need significant convincing before they'll even look at the details. (I<br>
tend to use -2 for that, but that's just me.) It's definitely bad the<br>
way the message is worded to imply that mere *submission* is unwelcome.<br>
If Gerrit supports it - sadly I don't think it does - I think we could<br>
have a much more constructive set of -1 reasons:<br>
<br>
* Needs style or packaging fixes (e.g. missing bug ID).<br>
<br>
* Needs a test.<br>
<br>
* Needs fixes for real bugs found in review.<br>
<br>
* Needs answers/explanations/comments.<br>
<br>
* Needs coordination with other patch XXXX.<br>
<br>
Alternatively, we could adopt an official set of such reasons as a<br>
matter of convention, much like we do with including the component<br>
in the one-line summary. Would that help?<br></blockquote><div> </div></div>Yes that will help. Are you saying we add it in the comments when we give '-1'?<br></div><div class="gmail_extra"><br clear="all"><br>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">Pranith<br></div></div>
</div></div>