<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On 21 June 2016 at 12:38, shwetha <span dir="ltr"><<a href="mailto:spandura@redhat.com" target="_blank">spandura@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">
<font face="Helvetica, Arial, sans-serif">Hi,<br>
</font>
<div><font face="Helvetica, Arial,
sans-serif"> <br>
</font><font face="Helvetica, Arial, sans-serif">Distaf test
framework currently uses a variable 'global_mode' which is for
selecting the mode in which the tests runs. <br>
<br>
</font> <font face="Helvetica, Arial, sans-serif">When
'global_mode' is set to 'True' we run the tests with the config
file configuration and ignores 'runs_on_volumes',
'runs_on_protocols'.</font><font face="Helvetica, Arial,
sans-serif"> <br>
<br>
When 'global_mode' is set to 'False' we use the configs
"runs_on_volumes" , "runs_on_protocols", reuse_setup as
specified in the doc_string or run_on_all_vols
/run_on_all_protocols/reuse_setup:true if doc_string not
specified , to automatically loop through all the specified
configs.<br>
<br>
</font><font face="Helvetica, Arial, sans-serif">'global_mode' is
not self-explanatory on what it does. Hence it would be a good
idea to change the name to something more appropriate. <br>
<br>
</font><font face="Helvetica, Arial, sans-serif">It can be changed
to 'ignore_auto_configs'. When 'ignore_auto_configs' is 'True'
we run the tests with config file configurations. When
'ignore_auto_configs' is set to 'False' we use the configs as
specified in doc_string. <br>
<br>
</font><font face="Helvetica, Arial, sans-serif">This is one
option. If any one else has more appropriate name to use please
do suggest.<br></font></div></div></blockquote><div><br></div><div>Well, I am going to suggest the same thing which I suggested before... "<b>Iterative_mode</b>" or "iteration"</div><div><br></div><div>The rational is simple. The 'global_mode' (as it is today) does loop through the possible (and permitted) volume type + mount protocol. Or in other words, it executes each test by iterating though the gluster volume and mount types. So in my mind it makes sense to have the flag as <b>iterative_mode</b>.</div><div><b><br></b></div><div>Also this is exactly one part of distaf which makes it pretty much tied to glusterfs automation. Because of the iteration distaf does over gluster volume type and guster mount protocols when flag is unset. So setting this flag makes it gluster independent ( more or less, still not completely). So keeping that in mind, we can also call it "<b>gluster_iterative_mode</b>" or "<b>gluster_iteration</b>" as well.</div><div><br></div><div>Best Regards,</div><div>Vishwanath</div><div><br></div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div bgcolor="#FFFFFF" text="#000000"><div><font face="Helvetica, Arial, sans-serif">
<br>
</font><font face="Helvetica, Arial, sans-serif">Regards,<br>
Shwetha</font><br>
<br>
</div>
<font face="Helvetica, Arial, sans-serif"><br>
</font>
</div>
<br>_______________________________________________<br>
Gluster-devel mailing list<br>
<a href="mailto:Gluster-devel@gluster.org">Gluster-devel@gluster.org</a><br>
<a href="http://www.gluster.org/mailman/listinfo/gluster-devel" rel="noreferrer" target="_blank">http://www.gluster.org/mailman/listinfo/gluster-devel</a><br></blockquote></div><br></div></div>