<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Apr 9, 2016 at 2:05 AM, Jeff Darcy <span dir="ltr"><<a href="mailto:jdarcy@redhat.com" target="_blank">jdarcy@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Upon further investigation, I've been able to determine that the problem<br>
lies in this line of our generic cleanup routine.<br>
<br>
type cleanup_lvm &>/dev/null && cleanup_lvm || true;<br>
<br>
This works great if snapshot.rc we're at the end of a test that included<br>
snapshot.rc (which defines cleanup_lvm), but we've generally been moving<br>
away from that in favor of calling it only at the beginning. Thus, when<br>
we go from a snapshot test to a non-snapshot test, the cleanup at the<br>
beginning of the latter does *not* clean up any LVM stuff that's left<br>
over. What might have been a simple and correctly attributed failure in<br>
the snapshot test can instead show up later. In this case, the sequence<br>
of events is as follows:<br>
<br>
1) bug-1322772 (snapshot) test starts glusterd<br>
<br>
2) bug-1322772 exits while the new glusterd is still initializing<br>
<br>
3) run-tests.sh looks for new core files and finds none<br>
<br>
4) run-tests.sh starts bug-1002207 (stripe) test<br>
<br>
5) glusterd from bug-1322772 dumps core<br>
<br>
6) bug-1002207 test completes<br>
<br>
7) run-tests.sh sees new core and misattributes it to bug-1002207<br>
<br>
The question is what to do about this. Unconditionally calling<br>
lvm_cleanup from generic cleanup is simple, but might make regression<br>
tests noticeably slower. Another possibility would be to change all<br>
snapshot tests to call cleanup (or at least cleanup_lvm) at the end, or<br>
use bash's "trap" mechanism to ensure the same. I'm not wild about any<br>
of those, but lean toward the "trap" approach. Anyone else have any<br>
opinions?<br></blockquote><div><br></div><div>I think each snapshot test script should call cleanup_lvm and trap is a <br></div><div>great suggestion.<br></div><div><br></div><div>atinm: Can you please look into the crash in the following test case?<br>bugs/snapshot/bug-1322772-real-path-fix-for-snapshot.t<br>
<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div class=""><div class="h5">_______________________________________________<br>
Gluster-devel mailing list<br>
<a href="mailto:Gluster-devel@gluster.org">Gluster-devel@gluster.org</a><br>
<a href="http://www.gluster.org/mailman/listinfo/gluster-devel" rel="noreferrer" target="_blank">http://www.gluster.org/mailman/listinfo/gluster-devel</a><br>
</div></div></blockquote></div><br></div></div>