<p dir="ltr"></p>
<p dir="ltr">-Atin<br>
Sent from one plus one<br>
On 09-Apr-2016 9:32 am, "Rajesh Joseph" <<a href="mailto:rjoseph@redhat.com">rjoseph@redhat.com</a>> wrote:<br>
><br>
><br>
><br>
> On Sat, Apr 9, 2016 at 2:05 AM, Jeff Darcy <<a href="mailto:jdarcy@redhat.com">jdarcy@redhat.com</a>> wrote:<br>
>><br>
>> Upon further investigation, I've been able to determine that the problem<br>
>> lies in this line of our generic cleanup routine.<br>
>><br>
>> type cleanup_lvm &>/dev/null && cleanup_lvm || true;<br>
>><br>
>> This works great if snapshot.rc we're at the end of a test that included<br>
>> snapshot.rc (which defines cleanup_lvm), but we've generally been moving<br>
>> away from that in favor of calling it only at the beginning. Thus, when<br>
>> we go from a snapshot test to a non-snapshot test, the cleanup at the<br>
>> beginning of the latter does *not* clean up any LVM stuff that's left<br>
>> over. What might have been a simple and correctly attributed failure in<br>
>> the snapshot test can instead show up later. In this case, the sequence<br>
>> of events is as follows:<br>
>><br>
>> 1) bug-1322772 (snapshot) test starts glusterd<br>
>><br>
>> 2) bug-1322772 exits while the new glusterd is still initializing<br>
>><br>
>> 3) run-tests.sh looks for new core files and finds none<br>
>><br>
>> 4) run-tests.sh starts bug-1002207 (stripe) test<br>
>><br>
>> 5) glusterd from bug-1322772 dumps core<br>
>><br>
>> 6) bug-1002207 test completes<br>
>><br>
>> 7) run-tests.sh sees new core and misattributes it to bug-1002207<br>
>><br>
>> The question is what to do about this. Unconditionally calling<br>
>> lvm_cleanup from generic cleanup is simple, but might make regression<br>
>> tests noticeably slower. Another possibility would be to change all<br>
>> snapshot tests to call cleanup (or at least cleanup_lvm) at the end, or<br>
>> use bash's "trap" mechanism to ensure the same. I'm not wild about any<br>
>> of those, but lean toward the "trap" approach. Anyone else have any<br>
>> opinions?<br>
><br>
><br>
> I think each snapshot test script should call cleanup_lvm and trap is a <br>
> great suggestion.<br>
><br>
> atinm: Can you please look into the crash in the following test case?<br>
> bugs/snapshot/bug-1322772-real-path-fix-for-snapshot.t</p>
<p dir="ltr">Do we have the link to the crash?<br>
><br>
> <br>
>><br>
>> _______________________________________________<br>
>> Gluster-devel mailing list<br>
>> <a href="mailto:Gluster-devel@gluster.org">Gluster-devel@gluster.org</a><br>
>> <a href="http://www.gluster.org/mailman/listinfo/gluster-devel">http://www.gluster.org/mailman/listinfo/gluster-devel</a><br>
><br>
><br>
><br>
> _______________________________________________<br>
> Gluster-devel mailing list<br>
> <a href="mailto:Gluster-devel@gluster.org">Gluster-devel@gluster.org</a><br>
> <a href="http://www.gluster.org/mailman/listinfo/gluster-devel">http://www.gluster.org/mailman/listinfo/gluster-devel</a><br></p>
<p dir="ltr">-Atin<br>
Sent from one plus one</p>