<p dir="ltr"><br>
On Mar 17, 2016 7:50 AM, "Pranith Kumar Karampuri" <<a href="mailto:pkarampu@redhat.com">pkarampu@redhat.com</a>> wrote:<br>
><br>
><br>
><br>
> On 03/16/2016 11:46 PM, Raghavendra Talur wrote:<br>
>><br>
>><br>
>><br>
>> On Wed, Mar 16, 2016 at 11:39 AM, Pranith Kumar Karampuri <<a href="mailto:pkarampu@redhat.com">pkarampu@redhat.com</a>> wrote:<br>
>>><br>
>>><br>
>>><br>
>>> On 03/16/2016 11:31 AM, Raghavendra Talur wrote:<br>
>>>><br>
>>>> Hi,<br>
>>>><br>
>>>> Lot many fixes to tests were found to be not back ported to 3.7 and other release branches.<br>
>>>> This causes tests to fail only in those branches and leaves the maintainers puzzled.<br>
>>>><br>
>>>> Also, this seems to be the case with back porting code fixes too.<br>
>>>><br>
>>>> I copied all the changes to tests/ dir on master to tests/ dir on 3.7 branch and posted a patch at <a href="http://review.gluster.org/#/c/13683/">http://review.gluster.org/#/c/13683/</a> . <br>
>>>><br>
>>>> This is failing for ./tests/bugs/distribute/bug-860663.t test :<br>
>>>> [10:39:11] Running tests in file ./tests/bugs/distribute/bug-860663.t<br>
>>>> tar: Removing leading `/' from member names<br>
>>>> ./tests/bugs/distribute/bug-860663.t .. <br>
>>>> 1..15<br>
>>>> ok 1, LINENUM:23<br>
>>>> ok 2, LINENUM:24<br>
>>>> ok 3, LINENUM:26<br>
>>>> ok 4, LINENUM:27<br>
>>>> ok 5, LINENUM:30<br>
>>>> ok 6, LINENUM:32<br>
>>>> ok 7, LINENUM:35<br>
>>>> not ok 8 , LINENUM:40<br>
>>>> FAILED COMMAND: ! gluster --mode=script --wignore volume rebalance patchy fix-layout start<br>
>>>> ok 9, LINENUM:42<br>
>>>> ok 10, LINENUM:43<br>
>>>> ok 11, LINENUM:45<br>
>>>> ok 12, LINENUM:47<br>
>>>> ok 13, LINENUM:50<br>
>>>> ok 14, LINENUM:51<br>
>>>> ok 15, LINENUM:55<br>
>>>> Failed 1/15 subtests <br>
>>>><br>
>>>> Given that it is a simple rebalance command that is failing I am assuming that a critical patch has not been back ported to 3.7, correct me if I am wrong.<br>
>>>><br>
>>>> I request every developer to take responsibility of back porting patches.<br>
>>>><br>
>>>><br>
>>>> Corollary question: Our test-framework is now capable of disabling tests for certain OS, certain branch etc. I would like to propose that we stop having tests in main git repo. This will remove need to back port test only fixes.<br>
>>><br>
>>><br>
>>> Some times what I do is to enhance existing test to handle extra cases based on new code that is added on master. Until the code-fix is not backported to lower versions, the tests are not valid. Should we mark such tests disabled when we do enhancements to .t files?<br>
>><br>
>><br>
>> Yes, this case would pose a problem and hence any new code change which introduces a feature should be tested by a new test(not by modifying existing test) and bug fix should be immediately backported along with test fix.<br>
><br>
><br>
> As Atin mentioned in another mail, it is better to have code + test files which test code together.</p>
<p dir="ltr">Makes sense, so proactive back porting of fixes is what we require. </p>
<p dir="ltr">><br>
> Pranith<br>
><br>
>> <br>
>>><br>
>>><br>
>>> Pranith<br>
>>>><br>
>>>><br>
>>>><br>
>>>> Thanks,<br>
>>>> Raghavendra Talur<br>
>>>><br>
>>>><br>
>>>><br>
>>>> _______________________________________________<br>
>>>> Gluster-devel mailing list<br>
>>>> <a href="mailto:Gluster-devel@gluster.org">Gluster-devel@gluster.org</a><br>
>>>> <a href="http://www.gluster.org/mailman/listinfo/gluster-devel">http://www.gluster.org/mailman/listinfo/gluster-devel</a><br>
>>><br>
>>><br>
>><br>
><br>
</p>