<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Mar 16, 2016 at 11:59 PM, Atin Mukherjee <span dir="ltr"><<a href="mailto:atin.mukherjee83@gmail.com" target="_blank">atin.mukherjee83@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><p dir="ltr"></p>
<p dir="ltr">-Atin<br>
Sent from one plus one</p><div><div class="h5"><br>
On 16-Mar-2016 11:32 am, "Raghavendra Talur" <<a href="mailto:rtalur@redhat.com" target="_blank">rtalur@redhat.com</a>> wrote:<br>
><br>
> Hi,<br>
><br>
> Lot many fixes to tests were found to be not back ported to 3.7 and other release branches.<br>
> This causes tests to fail only in those branches and leaves the maintainers puzzled.<br>
><br>
> Also, this seems to be the case with back porting code fixes too.<br>
><br>
> I copied all the changes to tests/ dir on master to tests/ dir on 3.7 branch and posted a patch at <a href="http://review.gluster.org/#/c/13683/" target="_blank">http://review.gluster.org/#/c/13683/</a> . <br>
><br>
> This is failing for ./tests/bugs/distribute/bug-860663.t test :<br>
> [10:39:11] Running tests in file ./tests/bugs/distribute/bug-860663.t<br>
> tar: Removing leading `/' from member names<br>
> ./tests/bugs/distribute/bug-860663.t .. <br>
> 1..15<br>
> ok 1, LINENUM:23<br>
> ok 2, LINENUM:24<br>
> ok 3, LINENUM:26<br>
> ok 4, LINENUM:27<br>
> ok 5, LINENUM:30<br>
> ok 6, LINENUM:32<br>
> ok 7, LINENUM:35<br>
> not ok 8 , LINENUM:40<br>
> FAILED COMMAND: ! gluster --mode=script --wignore volume rebalance patchy fix-layout start<br>
> ok 9, LINENUM:42<br>
> ok 10, LINENUM:43<br>
> ok 11, LINENUM:45<br>
> ok 12, LINENUM:47<br>
> ok 13, LINENUM:50<br>
> ok 14, LINENUM:51<br>
> ok 15, LINENUM:55<br>
> Failed 1/15 subtests <br>
><br>
> Given that it is a simple rebalance command that is failing I am assuming that a critical patch has not been back ported to 3.7, correct me if I am wrong.<br>
><br>
> I request every developer to take responsibility of back porting patches.<br>
><br>
><br>
> Corollary question: Our test-framework is now capable of disabling tests for certain OS, certain branch etc. I would like to propose that we stop having tests in main git repo. This will remove need to back port test only fixes.<br></div></div>
Where are you going to host these .t files then?</blockquote><div><br></div><div>Proposal was a separate git repo for tests. It seems very unlikely to maintain it separately though.</div><div>Basically what I am looking for is making tests/ dir independent of git branch but still part of the git repo.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class=""><br>
><br>
><br>
> Thanks,<br>
> Raghavendra Talur<br>
><br>
><br>
> _______________________________________________<br>
> Gluster-devel mailing list<br>
> <a href="mailto:Gluster-devel@gluster.org" target="_blank">Gluster-devel@gluster.org</a><br>
> <a href="http://www.gluster.org/mailman/listinfo/gluster-devel" target="_blank">http://www.gluster.org/mailman/listinfo/gluster-devel</a><br>
</span><p></p>
</blockquote></div><br></div></div>