<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Mar 16, 2016 at 11:39 AM, Pranith Kumar Karampuri <span dir="ltr"><<a href="mailto:pkarampu@redhat.com" target="_blank">pkarampu@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"><div><div class="h5">
<br>
<br>
<div>On 03/16/2016 11:31 AM, Raghavendra
Talur wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">Hi,
<div><br>
</div>
<div>Lot many fixes to tests were found to be not back ported to
3.7 and other release branches.</div>
<div>This causes tests to fail only in those branches and leaves
the maintainers puzzled.</div>
<div><br>
</div>
<div>Also, this seems to be the case with back porting code
fixes too.</div>
<div><br>
</div>
<div>I copied all the changes to tests/ dir on master to tests/
dir on 3.7 branch and posted a patch at <a href="http://review.gluster.org/#/c/13683/" target="_blank">http://review.gluster.org/#/c/13683/</a>
. </div>
<div><br>
</div>
<div>This is failing for ./tests/bugs/distribute/bug-860663.t
test :</div>
<div>
<div>[10:39:11] Running tests in file
./tests/bugs/distribute/bug-860663.t</div>
<div>tar: Removing leading `/' from member names</div>
<div>./tests/bugs/distribute/bug-860663.t .. </div>
<div>1..15</div>
<div>ok 1, LINENUM:23</div>
<div>ok 2, LINENUM:24</div>
<div>ok 3, LINENUM:26</div>
<div>ok 4, LINENUM:27</div>
<div>ok 5, LINENUM:30</div>
<div>ok 6, LINENUM:32</div>
<div>ok 7, LINENUM:35</div>
<div>not ok 8 , LINENUM:40</div>
<div>FAILED COMMAND: ! gluster --mode=script --wignore volume
rebalance patchy fix-layout start</div>
<div>ok 9, LINENUM:42</div>
<div>ok 10, LINENUM:43</div>
<div>ok 11, LINENUM:45</div>
<div>ok 12, LINENUM:47</div>
<div>ok 13, LINENUM:50</div>
<div>ok 14, LINENUM:51</div>
<div>ok 15, LINENUM:55</div>
<div>Failed 1/15 subtests </div>
</div>
<div><br>
</div>
<div>Given that it is a simple rebalance command that is failing
I am assuming that a critical patch has not been back ported
to 3.7, correct me if I am wrong.</div>
<div><br>
</div>
<div>I request every developer to take responsibility of back
porting patches.</div>
<div><br>
</div>
<div><br>
</div>
<div>Corollary question: Our test-framework is now capable of
disabling tests for certain OS, certain branch etc. I would
like to propose that we stop having tests in main git repo.
This will remove need to back port test only fixes.</div>
</div>
</blockquote>
<br></div></div>
Some times what I do is to enhance existing test to handle extra
cases based on new code that is added on master. Until the code-fix
is not backported to lower versions, the tests are not valid. Should
we mark such tests disabled when we do enhancements to .t files?<br></div></blockquote><div><br></div><div>Yes, this case would pose a problem and hence any new code change which introduces a feature should be tested by a new test(not by modifying existing test) and bug fix should be immediately backported along with test fix.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div bgcolor="#FFFFFF" text="#000000">
<br>
Pranith<br>
<blockquote type="cite">
<div dir="ltr">
<div><br>
</div>
<div><br>
</div>
<div>Thanks,</div>
<div>Raghavendra Talur</div>
<div><br>
</div>
</div>
<br>
<fieldset></fieldset>
<br>
<pre>_______________________________________________
Gluster-devel mailing list
<a href="mailto:Gluster-devel@gluster.org" target="_blank">Gluster-devel@gluster.org</a>
<a href="http://www.gluster.org/mailman/listinfo/gluster-devel" target="_blank">http://www.gluster.org/mailman/listinfo/gluster-devel</a></pre>
</blockquote>
<br>
</div>
</blockquote></div><br></div></div>