<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
<br>
<div class="moz-cite-prefix">On 03/16/2016 11:31 AM, Raghavendra
Talur wrote:<br>
</div>
<blockquote
cite="mid:CAM5jxn82sTxsPNBbuibBT9XG6GAz0sEh+4x806WS=1_oH98yHQ@mail.gmail.com"
type="cite">
<div dir="ltr">Hi,
<div><br>
</div>
<div>Lot many fixes to tests were found to be not back ported to
3.7 and other release branches.</div>
<div>This causes tests to fail only in those branches and leaves
the maintainers puzzled.</div>
<div><br>
</div>
<div>Also, this seems to be the case with back porting code
fixes too.</div>
<div><br>
</div>
<div>I copied all the changes to tests/ dir on master to tests/
dir on 3.7 branch and posted a patch at <a
moz-do-not-send="true"
href="http://review.gluster.org/#/c/13683/">http://review.gluster.org/#/c/13683/</a>
. </div>
<div><br>
</div>
<div>This is failing for ./tests/bugs/distribute/bug-860663.t
test :</div>
<div>
<div>[10:39:11] Running tests in file
./tests/bugs/distribute/bug-860663.t</div>
<div>tar: Removing leading `/' from member names</div>
<div>./tests/bugs/distribute/bug-860663.t .. </div>
<div>1..15</div>
<div>ok 1, LINENUM:23</div>
<div>ok 2, LINENUM:24</div>
<div>ok 3, LINENUM:26</div>
<div>ok 4, LINENUM:27</div>
<div>ok 5, LINENUM:30</div>
<div>ok 6, LINENUM:32</div>
<div>ok 7, LINENUM:35</div>
<div>not ok 8 , LINENUM:40</div>
<div>FAILED COMMAND: ! gluster --mode=script --wignore volume
rebalance patchy fix-layout start</div>
<div>ok 9, LINENUM:42</div>
<div>ok 10, LINENUM:43</div>
<div>ok 11, LINENUM:45</div>
<div>ok 12, LINENUM:47</div>
<div>ok 13, LINENUM:50</div>
<div>ok 14, LINENUM:51</div>
<div>ok 15, LINENUM:55</div>
<div>Failed 1/15 subtests </div>
</div>
<div><br>
</div>
<div>Given that it is a simple rebalance command that is failing
I am assuming that a critical patch has not been back ported
to 3.7, correct me if I am wrong.</div>
<div><br>
</div>
<div>I request every developer to take responsibility of back
porting patches.</div>
<div><br>
</div>
<div><br>
</div>
<div>Corollary question: Our test-framework is now capable of
disabling tests for certain OS, certain branch etc. I would
like to propose that we stop having tests in main git repo.
This will remove need to back port test only fixes.</div>
</div>
</blockquote>
<br>
Some times what I do is to enhance existing test to handle extra
cases based on new code that is added on master. Until the code-fix
is not backported to lower versions, the tests are not valid. Should
we mark such tests disabled when we do enhancements to .t files?<br>
<br>
Pranith<br>
<blockquote
cite="mid:CAM5jxn82sTxsPNBbuibBT9XG6GAz0sEh+4x806WS=1_oH98yHQ@mail.gmail.com"
type="cite">
<div dir="ltr">
<div><br>
</div>
<div><br>
</div>
<div>Thanks,</div>
<div>Raghavendra Talur</div>
<div><br>
</div>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
Gluster-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Gluster-devel@gluster.org">Gluster-devel@gluster.org</a>
<a class="moz-txt-link-freetext" href="http://www.gluster.org/mailman/listinfo/gluster-devel">http://www.gluster.org/mailman/listinfo/gluster-devel</a></pre>
</blockquote>
<br>
</body>
</html>