<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On 9 March 2016 at 19:39, Kaushal M <span dir="ltr"><<a href="mailto:kshlmster@gmail.com" target="_blank">kshlmster@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Wed, Mar 9, 2016 at 7:02 PM, M S Vishwanath Bhat <<a href="mailto:msvbhat@gmail.com">msvbhat@gmail.com</a>> wrote:<br>
> Hi,<br>
><br>
> When we were discussing about the readiness of distaf for upstream test<br>
> automation, this question came up, That we should have a process or workflow<br>
> for proposing, reviewing and including the tests somewhere.<br>
><br>
> Right now the tests are part of distaf repository<br>
> (<a href="http://github.com/gluster/distaf" rel="noreferrer" target="_blank">github.com/gluster/distaf</a>) itself. And contributing to distaf is by sending<br>
> a PR. But we want this to be included in gerrit so that review and<br>
> contributing process becomes much easier. But the question still remains...<br>
> where? Right now I can think of below options.<br>
><br>
> * Use the same distaf repo in github for tests as well.<br>
> * Create a separate repo distaf_gluster_tests (or something similar) and<br>
> have all the tests there.<br>
> * Or have a tests/distaf/ directory inside glusterfs repository. And this<br>
> tests can be bundled in a rpm and distributed. This directory will have both<br>
> the test cases and related library functions.<br>
<br>
</span>I prefer this approach. It makes it easier for developers to submit<br>
tests along with their changes, as is the case with our regression<br>
tests now.<br>
<br>
By library functions, I'm assuming you mean helper libraries related<br>
to gluster, which will be used in the tests which will be written.<br></blockquote><div><br></div><div>Yes, I mean helper functions which are related to gluster. The framework itself will be made a python package. At least that's the plan.</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I'm also in favor of including them here as well. This will help keep<br>
DiSTAF free of an Gluster specific cruft and allow it to be (possibly)<br>
reusable by others.<br></blockquote><div><br></div><div>The recent changes makes it specific to gluster, but very easy to make it generic.</div><div><br></div><div>Best Regards,</div><div>Vishwanath</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<span class=""><br>
><br>
> Please let us know what your preferred option is. If you have any other<br>
> ideas, please let us know as well.<br>
><br>
> Best Regards,<br>
> Vishwanath<br>
><br>
><br>
</span>> _______________________________________________<br>
> Gluster-devel mailing list<br>
> <a href="mailto:Gluster-devel@gluster.org">Gluster-devel@gluster.org</a><br>
> <a href="http://www.gluster.org/mailman/listinfo/gluster-devel" rel="noreferrer" target="_blank">http://www.gluster.org/mailman/listinfo/gluster-devel</a><br>
</blockquote></div><br></div></div>