<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Feb 10, 2016 at 8:29 PM, Emmanuel Dreyfus <span dir="ltr"><<a href="mailto:manu@netbsd.org" target="_blank">manu@netbsd.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><span class="">On Wed, Feb 10, 2016 at 07:30:24PM +0530, Raghavendra Talur wrote:<br>
> Any comments before I merge the patch <a href="http://review.gluster.org/#/c/13393/" rel="noreferrer" target="_blank">http://review.gluster.org/#/c/13393/</a> ?<br>
<br>
</span>The proposal has the merit of adressing the multi-OS case, but fails<br>
to address future OS addition. If it does not matter to change the<br>
naming the day we add another OS, it is fine for me. Otherwise, I<br>
adivse using a 8 bit hex value that will be fine for a long time:<br>
<br>
K01-test.t kills for Linux<br>
K02-test.t kills for NetBSD<br>
K03-test.t kills for both Linux and NetBSD<br>
K04-test.t kills for new OS 1 we would add later.<br>
K08-test.t kills for new OS 2 we would add later.<br>
K10-test.t kills for new OS 3 we would add later.<br>
K19-tets.t kills for Linux, new OS 2 and new OS 3...<br>
<br>
Of course if we add more than 8 OS in regression that is not enough,<br>
but you can start with a 16 bit value if you prefer :-)<br>
<span class=""><font color="#888888"><br></font></span></blockquote><div><br></div><div>OK, I have updated the patch and replied to Manu's question and Jeff's question on the patch itself.</div><div>The tests passed on the first run itself, except for the NetBSD with "another test running on slave" error.</div><div>I consider passing on first run itself as a great improvement compared to our current state.</div><div><br></div><div>Please review the patch: <a href="http://review.gluster.org/#/c/13393/">http://review.gluster.org/#/c/13393/</a></div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><span class=""><font color="#888888">
--<br>
Emmanuel Dreyfus<br>
<a href="mailto:manu@netbsd.org">manu@netbsd.org</a><br>
</font></span></blockquote></div><br></div></div>