<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jan 13, 2016 at 6:32 PM, Niels de Vos <span dir="ltr"><<a href="mailto:ndevos@redhat.com" target="_blank">ndevos@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Wed, Jan 13, 2016 at 04:42:12PM +0530, Raghavendra Talur wrote:<br>
> On Wed, Jan 13, 2016 at 4:25 PM, Kaleb Keithley <<a href="mailto:kkeithle@redhat.com">kkeithle@redhat.com</a>> wrote:<br>
><br>
> > > From: "Niels de Vos" <<a href="mailto:ndevos@redhat.com">ndevos@redhat.com</a>><br>
> > ><br>
> > > On Wed, Jan 13, 2016 at 09:56:54AM +0530, Atin Mukherjee wrote:<br>
> > > > Hi Raghavendra,<br>
> > > ><br>
> > > > I noticed that for the below patches Gluster Build system hasn't voted<br>
> > > > and hence the verified flag doesn't have an ack from it even if the<br>
> > > > regression has passed. I think something is fishy in the script now,<br>
> > > > mind having a look?<br>
> > > ><br>
> > > > <a href="http://review.gluster.org/#/c/13222/" rel="noreferrer" target="_blank">http://review.gluster.org/#/c/13222/</a><br>
> > > > <a href="http://review.gluster.org/#/c/13210/" rel="noreferrer" target="_blank">http://review.gluster.org/#/c/13210/</a><br>
> > ><br>
> > > I've manually approved these now. No idea what caused the voting to have<br>
> > > failed. The votes are done through an ssh command in the regression test<br>
> > > itself, it is not a property of the test job (which is an option, but<br>
> > > gives us less flexibility).<br>
> > ><br>
> > > Maybe someone can figure out what went wrong? I could not see anything<br>
> > > in the console log that suggested a problem.<br>
> ><br>
> > Did the other tests (smoke, rpmbuild, version-and-branch) run after the<br>
> > regression?<br>
> ><br>
> > The logic is broken and if the other tests are delayed and will erase the<br>
> > regression +1Verified.<br>
> ><br>
><br>
> Is this still applicable after removing the voting from smoke, rpmbuild and<br>
> other such projects?<br>
> IIRC, we removed voting lines from these scripts because of the race reason.<br>
<br>
</span>It seems to be disabled, yes. But I do not know the reason for it, or<br>
when and where this was discussed/announced. It surely was surprising me<br>
because the FreeBSD failure might have been noticed much earlier.<br>
<br>
Got any pointers?<br></blockquote><div><br></div><div>I don't remember if I came to know this through email or IRC and I am not able to find using google.</div><div>My guess is that it was done about a year ago. Kaushal might know more about it.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Thanks,<br>
Niels<br>
</blockquote></div><br></div></div>