<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jan 13, 2016 at 4:25 PM, Kaleb Keithley <span dir="ltr"><<a href="mailto:kkeithle@redhat.com" target="_blank">kkeithle@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">> From: "Niels de Vos" <<a href="mailto:ndevos@redhat.com">ndevos@redhat.com</a>><br>
<span class="">><br>
> On Wed, Jan 13, 2016 at 09:56:54AM +0530, Atin Mukherjee wrote:<br>
> > Hi Raghavendra,<br>
> ><br>
> > I noticed that for the below patches Gluster Build system hasn't voted<br>
> > and hence the verified flag doesn't have an ack from it even if the<br>
> > regression has passed. I think something is fishy in the script now,<br>
> > mind having a look?<br>
> ><br>
> > <a href="http://review.gluster.org/#/c/13222/" rel="noreferrer" target="_blank">http://review.gluster.org/#/c/13222/</a><br>
> > <a href="http://review.gluster.org/#/c/13210/" rel="noreferrer" target="_blank">http://review.gluster.org/#/c/13210/</a><br>
><br>
> I've manually approved these now. No idea what caused the voting to have<br>
> failed. The votes are done through an ssh command in the regression test<br>
> itself, it is not a property of the test job (which is an option, but<br>
> gives us less flexibility).<br>
><br>
> Maybe someone can figure out what went wrong? I could not see anything<br>
> in the console log that suggested a problem.<br>
<br>
</span>Did the other tests (smoke, rpmbuild, version-and-branch) run after the regression?<br>
<br>
The logic is broken and if the other tests are delayed and will erase the regression +1Verified.<br></blockquote><div><br></div><div>Is this still applicable after removing the voting from smoke, rpmbuild and other such projects?</div><div>IIRC, we removed voting lines from these scripts because of the race reason.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
--<br>
<br>
Kaleb<br>
_______________________________________________<br>
Gluster-devel mailing list<br>
<a href="mailto:Gluster-devel@gluster.org">Gluster-devel@gluster.org</a><br>
<a href="http://www.gluster.org/mailman/listinfo/gluster-devel" rel="noreferrer" target="_blank">http://www.gluster.org/mailman/listinfo/gluster-devel</a><br>
</blockquote></div><br></div></div>