<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Jan 8, 2016 at 12:28 PM, Kaushal M <span dir="ltr"><<a href="mailto:kshlmster@gmail.com" target="_blank">kshlmster@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">On Fri, Jan 8, 2016 at 12:10 PM, Kaushal M <<a href="mailto:kshlmster@gmail.com">kshlmster@gmail.com</a>> wrote:<br>
> On Fri, Jan 8, 2016 at 12:03 PM, Raghavendra Talur <<a href="mailto:rtalur@redhat.com">rtalur@redhat.com</a>> wrote:<br>
>> Top posting, this is a very old thread.<br>
>><br>
>> Keeping in view the recent NetBSD problems and the number of bugs creeping<br>
>> in, I suggest we do these things right now:<br>
>><br>
>> a. Change the gerrit merge type to fast forward only.<br>
>> As explained below in the thread, with our current setup even if both PatchA<br>
>> and PatchB pass regression separately when both are merged it is possible<br>
>> that a functional bug creeps in.<br>
>> This is the only solution to prevent that from happening.<br>
>> I will work with Kaushal to get this done.<br>
>><br>
>> b. In Jenkins, remove gerrit trigger and make it a manual operation<br>
><br>
> Making it manual might be too much work for maintainers. I suggest (as<br>
> I've suggested before) we make regressions trigger when a change has<br>
> been reviewed +2 by a maintainer.<br>
><br></div></div></blockquote><div><br></div><div>Makes sense. I have disabled it completely for now and lets keep it that way till</div><div>developers realize it(a day should be enough). We will change this trigger to on Code Review +2 by tomorrow.</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">
>><br>
>> Too many developers use the upstream infra as a test cluster and it is<br>
>> *not*.<br>
>> It is a verification mechanism for maintainers to ensure that the patch does<br>
>> not cause regression.<br>
>> It is required that all developers run full regression on their machines<br>
>> before asking for reviews.<br>
>> Reviewers should review the patch only when the developer has given a +1<br>
>> verified on the patch.<br>
>> Again, I will work with Kaushal to get this done.<br>
>><br>
>> P.S: Stop using the "universal" jenkins account to trigger jenkins build if<br>
>> you are not a maintainer.<br>
>> If you are a maintainer and don't have your own jenkins account then get one<br>
>> soon!<br>
><br>
> I think I'll go ahead and remove this account.<br>
<br>
</div></div>This is done now.<br>
<br>
><br>
>><br>
>> Thanks,<br>
>> Raghavendra Talur<br>
>><br>
</blockquote></div><br></div></div>