<div dir="ltr"><server_setvolume><br><br><div> */<br> if (op_ret && !xl) {<br> /* We would have set the xl_private of the transport to the <br> * @conn. But if we have put the connection i.e shutting down <br> * the connection, then we should set xl_private to NULL as it <br> * would be pointing to a freed memory and would segfault when <br> * accessed upon getting DISCONNECT. <br> */<br> gf_client_put (client, NULL);<br> req->trans->xl_private = NULL;<br> }<br><br></div><div></server_setvolume><br><br></div><div>The crash is in gf_client_put. Code in gf_client_put reveals that client is dereferenced without NULL check. I am suspecting that this crash might've been uncovered/caused by [1] which fails any setvolume requests before server graph initialization (in which case client is NULL). Will send out a patch.<br><br>[1] <a href="http://review.gluster.org/11490">http://review.gluster.org/11490</a><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Jul 3, 2015 at 6:02 PM, Raghavendra Bhat <span dir="ltr"><<a href="mailto:rabhat@redhat.com" target="_blank">rabhat@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On 07/03/2015 03:37 PM, Atin Mukherjee wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<a href="http://build.gluster.org/job/rackspace-regression-2GB-triggered/11898/consoleFull" rel="noreferrer" target="_blank">http://build.gluster.org/job/rackspace-regression-2GB-triggered/11898/consoleFull</a><br>
has caused a crash in snapd with the following bt:<br>
</blockquote>
<br></span>
This seem to have crashed in server_setvolume (i.e. before the graph could be properly made available for i/o. snapview-server xlator is yet to come into the picture). But still I will try to reproduce it on my local setup and see what might be causing this.<br>
<br>
<br>
Regards,<br>
Raghavendra Bhat<div class="HOEnZb"><div class="h5"><br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
#0 0x00007f11e2ed3ded in gf_client_put (client=0x0, detached=0x0)<br>
at<br>
/home/jenkins/root/workspace/rackspace-regression-2GB-triggered/libglusterfs/src/client_t.c:294<br>
#1 0x00007f11d4eeac96 in server_setvolume (req=0x7f11c000195c)<br>
at<br>
/home/jenkins/root/workspace/rackspace-regression-2GB-triggered/xlators/protocol/server/src/server-handshake.c:710<br>
#2 0x00007f11e2c1e05c in rpcsvc_handle_rpc_call (svc=0x7f11d001b160,<br>
trans=0x7f11c0000ac0, msg=0x7f11c0001810)<br>
at<br>
/home/jenkins/root/workspace/rackspace-regression-2GB-triggered/rpc/rpc-lib/src/rpcsvc.c:698<br>
#3 0x00007f11e2c1e3cf in rpcsvc_notify (trans=0x7f11c0000ac0,<br>
mydata=0x7f11d001b160, event=RPC_TRANSPORT_MSG_RECEIVED,<br>
data=0x7f11c0001810) at<br>
/home/jenkins/root/workspace/rackspace-regression-2GB-triggered/rpc/rpc-lib/src/rpcsvc.c:792<br>
#4 0x00007f11e2c23ad7 in rpc_transport_notify (this=0x7f11c0000ac0,<br>
event=RPC_TRANSPORT_MSG_RECEIVED, data=0x7f11c0001810)<br>
at<br>
/home/jenkins/root/workspace/rackspace-regression-2GB-triggered/rpc/rpc-lib/src/rpc-transport.c:538<br>
#5 0x00007f11d841787b in socket_event_poll_in (this=0x7f11c0000ac0)<br>
at<br>
/home/jenkins/root/workspace/rackspace-regression-2GB-triggered/rpc/rpc-transport/socket/src/socket.c:2285<br>
#6 0x00007f11d8417dd1 in socket_event_handler (fd=13, idx=3,<br>
data=0x7f11c0000ac0, poll_in=1, poll_out=0, poll_err=0)<br>
at<br>
/home/jenkins/root/workspace/rackspace-regression-2GB-triggered/rpc/rpc-transport/socket/src/socket.c:2398<br>
#7 0x00007f11e2ed79ec in event_dispatch_epoll_handler<br>
(event_pool=0x13bb040, event=0x7f11d4eb9e70)<br>
at<br>
/home/jenkins/root/workspace/rackspace-regression-2GB-triggered/libglusterfs/src/event-epoll.c:570<br>
#8 0x00007f11e2ed7dda in event_dispatch_epoll_worker (data=0x7f11d000dc10)<br>
at<br>
/home/jenkins/root/workspace/rackspace-regression-2GB-triggered/libglusterfs/src/event-epoll.c:673<br>
#9 0x00007f11e213e9d1 in start_thread () from ./lib64/libpthread.so.0<br>
#10 0x00007f11e1aa88fd in clone () from ./lib64/libc.so.6<br>
<br>
</blockquote>
<br></div></div><div class="HOEnZb"><div class="h5">
_______________________________________________<br>
Gluster-devel mailing list<br>
<a href="mailto:Gluster-devel@gluster.org" target="_blank">Gluster-devel@gluster.org</a><br>
<a href="http://www.gluster.org/mailman/listinfo/gluster-devel" rel="noreferrer" target="_blank">http://www.gluster.org/mailman/listinfo/gluster-devel</a><br>
</div></div></blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature">Raghavendra G<br></div>
</div>