<p dir="ltr"></p>
<p dir="ltr">Sent from Samsung Galaxy S4<br>
On 13 Jun 2015 14:11, "Raghavendra Talur" <<a href="mailto:raghavendra.talur@gmail.com">raghavendra.talur@gmail.com</a>> wrote:<br>
><br>
><br>
><br>
> On Sat, Jun 13, 2015 at 1:36 PM, Niels de Vos <<a href="mailto:ndevos@redhat.com">ndevos@redhat.com</a>> wrote:<br>
>><br>
>> On Sat, Jun 13, 2015 at 01:15:04PM +0530, Raghavendra Talur wrote:<br>
>> > On Sat, Jun 13, 2015 at 1:00 PM, Atin Mukherjee <<a href="mailto:atin.mukherjee83@gmail.com">atin.mukherjee83@gmail.com</a>><br>
>> > wrote:<br>
>> ><br>
>> > > Sent from Samsung Galaxy S4<br>
>> > > On 13 Jun 2015 12:58, "Anand Nekkunti" <<a href="mailto:anekkunt@redhat.com">anekkunt@redhat.com</a>> wrote:<br>
>> > > ><br>
>> > > > Hi All<br>
>> > > > Rebalance is not working in single node cluster environment ( current<br>
>> > > test frame work ). I am getting error in below test , it seems re-balance<br>
>> > > is not migrated to current cluster test framework.<br>
>> > > Could you pin point which test case fails and what log do you see?<br>
>> > > ><br>
>> > > > cleanup;<br>
>> > > > TEST launch_cluster 2;<br>
>> > > > TEST $CLI_1 peer probe $H2;<br>
>> > > ><br>
>> > > > EXPECT_WITHIN $PROBE_TIMEOUT 1 check_peers<br>
>> > > ><br>
>> > > > $CLI_1 volume create $V0 $H1:$B1/$V0 $H2:$B2/$V0<br>
>> > > > EXPECT 'Created' volinfo_field $V0 'Status';<br>
>> > > ><br>
>> > > > $CLI_1 volume start $V0<br>
>> > > > EXPECT 'Started' volinfo_field $V0 'Status';<br>
>> > > ><br>
>> > > > #Mount FUSE<br>
>> > > > TEST glusterfs -s $H1 --volfile-id=$V0 $M0;<br>
>> > > ><br>
>> > > > TEST mkdir $M0/dir{1..4};<br>
>> > > > TEST touch $M0/dir{1..4}/files{1..4};<br>
>> > > ><br>
>> > > > TEST $CLI_1 volume add-brick $V0 $H1:$B1/${V0}1 $H2:$B2/${V0}1<br>
>> > > ><br>
>> > > > TEST $CLI_1 volume rebalance $V0 start<br>
>> > > ><br>
>> > > > EXPECT_WITHIN 60 "completed" CLI_1_rebalance_status_field $V0<br>
>> > > ><br>
>> > > > $CLI_2 volume status $V0<br>
>> > > > EXPECT 'Started' volinfo_field $V0 'Status';<br>
>> > > ><br>
>> > > > cleanup;<br>
>> > > ><br>
>> > > > Regards<br>
>> > > > Anand.N<br>
>> > > ><br>
>> > > ><br>
>> > > ><br>
>> > > > _______________________________________________<br>
>> > > > Gluster-devel mailing list<br>
>> > > > <a href="mailto:Gluster-devel@gluster.org">Gluster-devel@gluster.org</a><br>
>> > > > <a href="http://www.gluster.org/mailman/listinfo/gluster-devel">http://www.gluster.org/mailman/listinfo/gluster-devel</a><br>
>> > > ><br>
>> > ><br>
>> > > _______________________________________________<br>
>> > > Gluster-devel mailing list<br>
>> > > <a href="mailto:Gluster-devel@gluster.org">Gluster-devel@gluster.org</a><br>
>> > > <a href="http://www.gluster.org/mailman/listinfo/gluster-devel">http://www.gluster.org/mailman/listinfo/gluster-devel</a><br>
>> > ><br>
>> > ><br>
>> > If it is a crash of glusterd when you do rebalance start, it is because of<br>
>> > FORTIFY_FAIL in libc.<br>
>> > Here is the patch that Susant has already sent:<br>
>> > <a href="http://review.gluster.org/#/c/11090/">http://review.gluster.org/#/c/11090/</a><br>
>> ><br>
>> > You can verify that it is the same crash by checking the core in gdb; a<br>
>> > SIGABRT would be raised<br>
>> > after strncpy.<br>
>><br>
>> Sounds like we should use _FORTIFY_SOURCE for running our regression<br>
>> tests? Patches for build.sh or one of the other scripts are welcome!<br>
>><br>
>> You can get them here:<br>
>> <a href="https://github.com/gluster/glusterfs-patch-acceptance-tests/">https://github.com/gluster/glusterfs-patch-acceptance-tests/</a><br>
>><br>
>> Thanks,<br>
>> Niels<br>
><br>
><br>
> Yes, Kaushal and Vijay also agreed to have our regression use this flag.<br>
><br>
> I have discovered a problem though. For glibc to detect these possible overflows,<br>
> we need to have -D_FORTIFY_SOURCE at level 2 and -O optimization flag at minimum of<br>
> 1 with 2 as recommended.<br>
> Read this for more info: <a href="https://gcc.gnu.org/ml/gcc-patches/2004-09/msg02055.html">https://gcc.gnu.org/ml/gcc-patches/2004-09/msg02055.html</a><br>
><br>
><br>
> Not sure if having -O2 will lead to debugging other cores difficult.<br>
><br>
><br>
> If nobody objects to O2, I think I have created a pull request correctly.<br>
> Please merge.<br>
> <a href="https://github.com/gluster/glusterfs-patch-acceptance-tests/pull/1">https://github.com/gluster/glusterfs-patch-acceptance-tests/pull/1</a><br>
I feel we should try to maintain uniformity at all the places as far as compilation flags are concerned.<br>
><br>
><br>
> -- <br>
> Raghavendra Talur <br>
><br>
</p>