<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
<br>
<div class="moz-cite-prefix">On 06/02/2015 08:08 PM,
<a class="moz-txt-link-abbreviated" href="mailto:fanghuang.data@yahoo.com">fanghuang.data@yahoo.com</a> wrote:<br>
</div>
<blockquote
cite="mid:532258617.2052263.1433255906395.JavaMail.yahoo@mail.yahoo.com"
type="cite">
<div style="color:#000; background-color:#fff;
font-family:Helvetica Neue-Light, Helvetica Neue Light,
Helvetica Neue, Helvetica, Arial, Lucida Grande,
Sans-Serif;font-size:13px">
<div id="yui_3_16_0_1_1433248361908_66699"><span>Hi all,</span></div>
<div id="yui_3_16_0_1_1433248361908_66699"><span><br>
</span></div>
<div id="yui_3_16_0_1_1433248361908_66699" dir="ltr">As I
reading the source codes of EC xlator, I am confused by the
cbk_list and answer_list defined in struct _ec_fop_data. Why
do we need two lists to combine the results of callback? </div>
<div id="yui_3_16_0_1_1433248361908_66699" dir="ltr"><br>
</div>
<div id="yui_3_16_0_1_1433248361908_66699" dir="ltr">Especially
for the answer_list, it is initialized
in ec_fop_data_allocate, then the nodes are added
in ec_cbk_data_allocate. Without being any accessed during the
lifetime of fop, the whole list finally is released
in ec_fop_cleanup. Do I miss something for the answer_list?</div>
</div>
</blockquote>
+Xavi.<br>
<br>
hi,<br>
The only reason I found is that It is easier to cleanup cbks
using answers_list. You can check ec_fop_cleanup() function on
latest master to check how this is. Combining of cbks is a bit
involved until you understand it but once you do, it is amazing. I
tried to add comments for this part of code and sent a patch, but we
forgot to merge it :-) <a class="moz-txt-link-freetext" href="http://review.gluster.org/9982">http://review.gluster.org/9982</a>. If you think
we can add more comments/change this part of code in a way it makes
it easier, let us know. We would love your feedback :-). Wait for
Xavi's response as well.<br>
<br>
Pranith<br>
<blockquote
cite="mid:532258617.2052263.1433255906395.JavaMail.yahoo@mail.yahoo.com"
type="cite">
<div style="color:#000; background-color:#fff;
font-family:Helvetica Neue-Light, Helvetica Neue Light,
Helvetica Neue, Helvetica, Arial, Lucida Grande,
Sans-Serif;font-size:13px">
<div id="yui_3_16_0_1_1433248361908_66739"> </div>
<div id="yui_3_16_0_1_1433248361908_66708">
<div id="yui_3_16_0_1_1433248361908_66707">Regards,
<br>
Fang Huang</div>
</div>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
Gluster-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Gluster-devel@gluster.org">Gluster-devel@gluster.org</a>
<a class="moz-txt-link-freetext" href="http://www.gluster.org/mailman/listinfo/gluster-devel">http://www.gluster.org/mailman/listinfo/gluster-devel</a>
</pre>
</blockquote>
<br>
</body>
</html>