<html><head></head><body>I've used clear-locks but to be fair, it's been a while and IIRC it was to recover from some other bug. <br><br><div class="gmail_quote">On April 8, 2015 6:13:44 AM PDT, Pranith Kumar Karampuri <pkarampu@redhat.com> wrote:<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail"><br />On 04/08/2015 06:20 PM, Justin Clift wrote:<br /><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"> Hi Pranith,<br /><br /> Hagarth mentioned in the weekly IRC meeting that you have an<br /> idea what might be causing the regression tests to generate<br /> cores?<br /><br /> Can you outline that quickly, as Jeff has some time and might<br /> be able to help narrow it down further. :)<br /><br /> (and these core files are really annoying :/)<br /></blockquote>I feel it is a lot like <br /><a href="https://bugzilla.redhat.com/show_bug.cgi?id=1184417">https://bugzilla.redhat.com/show_bug.cgi?id=1184417</a>. clear-locks command <br />is not handled properly after we did the client_t refactor. I believe <br />that is the reason for the crashes but I could be wrong. But After <br />looking at the code I feel there is high probability that this is the <br />issue. I didn't find it easy to fix. We
will need to change the lock <br />structure list maintenance heavily. Easier thing would be to disable <br />clear-locks functionality tests in the regression as it is not something <br />that is used by the users IMO and see if it indeed is the same issue. <br />There are 2 tests using this command:<br />18:34:00 :) ⚡ git grep clear-locks tests<br />tests/bugs/disperse/bug-1179050.t:TEST $CLI volume clear-locks $V0 / <br />kind all inode<br />tests/bugs/glusterd/bug-824753-file-locker.c: "gluster volume <br />clear-locks %s /%s kind all posix 0,7-1 |"<br /><br />If even after disabling these two tests it fails then we will need to <br />look again. I think jeff's patch which will find the test which <br />triggered the core should help here.<br /><br />Pranith<br /><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"><br /> Regards and best wishes,<br /><br /> Justin Clift<br /><br /> --<br /> GlusterFS - <a
href="http://www.gluster.org">http://www.gluster.org</a><br /><br /> An open source, distributed file system scaling to several<br /> petabytes, and handling thousands of clients.<br /><br /> My personal twitter: <a href="http://twitter.com/realjustinclift">twitter.com/realjustinclift</a></blockquote><br /><br /><hr /><br />Gluster-devel mailing list<br />Gluster-devel@gluster.org<br /><a href="http://www.gluster.org/mailman/listinfo/gluster-devel">http://www.gluster.org/mailman/listinfo/gluster-devel</a><br /></pre></blockquote></div><br>
-- <br>
Sent from my Android device with K-9 Mail. Please excuse my brevity.</body></html>