<div dir="ltr">We should probably check O_APPEND in open(). However the check in writev() is more important, since open() may not always be issued as in NFS.<br><div><br></div><div>Thanks</div></div><br><div class="gmail_quote">On Tue, 10 Mar 2015 at 23:52 Milind Changire <<a href="mailto:milindchangire@gmail.com">milindchangire@gmail.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><pre><span style="font-family:monospace,monospace">The ro_open(...) handler checks for O_WRONLY and O_RDWR flags but not the O_APPEND flag. However, the ro_writev(...) handler takes care of returning an EROFS appropriately. I guess that's probably the reason
the O_APPEND issue wasn't addressed so far.<br><br>Is it imperative that there should be a check for O_APPEND in ro_open(...) which might act as a fail-fast method rather than deferring until a ro_writev(...) is triggered?<br><br></span></pre><pre><span style="font-family:monospace,monospace">However, I haven't attempted creating a read-only file system and checking whether a valid file descriptor is returned or not in a O_APPEND mode.<br></span></pre><pre><span style="font-family:monospace,monospace"><br>Milind<br><br></span></pre></div>
______________________________<u></u>_________________<br>
Gluster-devel mailing list<br>
<a href="mailto:Gluster-devel@gluster.org" target="_blank">Gluster-devel@gluster.org</a><br>
<a href="http://www.gluster.org/mailman/listinfo/gluster-devel" target="_blank">http://www.gluster.org/<u></u>mailman/listinfo/gluster-devel</a><br>
</blockquote></div>